2011-01-01 16:40:36 +03:00
|
|
|
# encoding: utf-8
|
|
|
|
#
|
|
|
|
# Redmine - project management software
|
2012-05-05 16:56:53 +04:00
|
|
|
# Copyright (C) 2006-2012 Jean-Philippe Lang
|
2008-06-09 22:40:59 +04:00
|
|
|
#
|
|
|
|
# This program is free software; you can redistribute it and/or
|
|
|
|
# modify it under the terms of the GNU General Public License
|
|
|
|
# as published by the Free Software Foundation; either version 2
|
|
|
|
# of the License, or (at your option) any later version.
|
2011-05-07 10:47:05 +04:00
|
|
|
#
|
2008-06-09 22:40:59 +04:00
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
# GNU General Public License for more details.
|
2011-05-07 10:47:05 +04:00
|
|
|
#
|
2008-06-09 22:40:59 +04:00
|
|
|
# You should have received a copy of the GNU General Public License
|
|
|
|
# along with this program; if not, write to the Free Software
|
|
|
|
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
|
|
|
2010-12-13 02:24:34 +03:00
|
|
|
require File.expand_path('../../test_helper', __FILE__)
|
2008-06-09 22:40:59 +04:00
|
|
|
require 'attachments_controller'
|
|
|
|
|
|
|
|
# Re-raise errors caught by the controller.
|
|
|
|
class AttachmentsController; def rescue_action(e) raise e end; end
|
|
|
|
|
2009-09-13 21:14:35 +04:00
|
|
|
class AttachmentsControllerTest < ActionController::TestCase
|
2011-11-16 07:58:42 +04:00
|
|
|
fixtures :users, :projects, :roles, :members, :member_roles,
|
|
|
|
:enabled_modules, :issues, :trackers, :attachments,
|
2009-04-25 13:31:36 +04:00
|
|
|
:versions, :wiki_pages, :wikis, :documents
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2008-06-09 22:40:59 +04:00
|
|
|
def setup
|
|
|
|
@controller = AttachmentsController.new
|
|
|
|
@request = ActionController::TestRequest.new
|
|
|
|
@response = ActionController::TestResponse.new
|
|
|
|
User.current = nil
|
2011-12-16 21:52:47 +04:00
|
|
|
set_fixtures_attachments_directory
|
|
|
|
end
|
|
|
|
|
|
|
|
def teardown
|
|
|
|
set_tmp_attachments_directory
|
2008-06-09 22:40:59 +04:00
|
|
|
end
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2008-06-09 22:40:59 +04:00
|
|
|
def test_show_diff
|
2011-11-20 10:13:48 +04:00
|
|
|
['inline', 'sbs'].each do |dt|
|
2011-11-20 11:54:36 +04:00
|
|
|
# 060719210727_changeset_utf8.diff
|
2011-11-20 10:13:48 +04:00
|
|
|
get :show, :id => 14, :type => dt
|
|
|
|
assert_response :success
|
|
|
|
assert_template 'diff'
|
|
|
|
assert_equal 'text/html', @response.content_type
|
|
|
|
assert_tag 'th',
|
|
|
|
:attributes => {:class => /filename/},
|
|
|
|
:content => /issues_controller.rb\t\(révision 1484\)/
|
|
|
|
assert_tag 'td',
|
|
|
|
:attributes => {:class => /line-code/},
|
|
|
|
:content => /Demande créée avec succès/
|
|
|
|
end
|
2011-11-24 12:10:41 +04:00
|
|
|
set_tmp_attachments_directory
|
2011-01-01 16:40:36 +03:00
|
|
|
end
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2011-11-20 15:46:52 +04:00
|
|
|
def test_show_diff_replcace_cannot_convert_content
|
|
|
|
with_settings :repositories_encodings => 'UTF-8' do
|
|
|
|
['inline', 'sbs'].each do |dt|
|
|
|
|
# 060719210727_changeset_iso8859-1.diff
|
2011-11-22 04:08:02 +04:00
|
|
|
get :show, :id => 5, :type => dt
|
2011-11-20 15:46:52 +04:00
|
|
|
assert_response :success
|
|
|
|
assert_template 'diff'
|
|
|
|
assert_equal 'text/html', @response.content_type
|
|
|
|
assert_tag 'th',
|
|
|
|
:attributes => {:class => "filename"},
|
|
|
|
:content => /issues_controller.rb\t\(r\?vision 1484\)/
|
|
|
|
assert_tag 'td',
|
|
|
|
:attributes => {:class => /line-code/},
|
|
|
|
:content => /Demande cr\?\?e avec succ\?s/
|
|
|
|
end
|
2011-11-20 10:13:48 +04:00
|
|
|
end
|
2011-11-24 12:10:41 +04:00
|
|
|
set_tmp_attachments_directory
|
2008-06-09 22:40:59 +04:00
|
|
|
end
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2011-11-20 15:47:19 +04:00
|
|
|
def test_show_diff_latin_1
|
|
|
|
with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
|
2011-11-20 16:17:08 +04:00
|
|
|
['inline', 'sbs'].each do |dt|
|
|
|
|
# 060719210727_changeset_iso8859-1.diff
|
2011-11-22 04:08:02 +04:00
|
|
|
get :show, :id => 5, :type => dt
|
2011-11-20 16:17:08 +04:00
|
|
|
assert_response :success
|
|
|
|
assert_template 'diff'
|
|
|
|
assert_equal 'text/html', @response.content_type
|
|
|
|
assert_tag 'th',
|
|
|
|
:attributes => {:class => "filename"},
|
|
|
|
:content => /issues_controller.rb\t\(révision 1484\)/
|
|
|
|
assert_tag 'td',
|
|
|
|
:attributes => {:class => /line-code/},
|
|
|
|
:content => /Demande créée avec succès/
|
|
|
|
end
|
2011-11-20 15:47:19 +04:00
|
|
|
end
|
2011-11-24 12:10:41 +04:00
|
|
|
set_tmp_attachments_directory
|
2011-11-20 15:47:19 +04:00
|
|
|
end
|
|
|
|
|
2012-02-04 10:23:38 +04:00
|
|
|
def test_save_diff_type
|
|
|
|
@request.session[:user_id] = 1 # admin
|
|
|
|
user = User.find(1)
|
|
|
|
get :show, :id => 5
|
|
|
|
assert_response :success
|
|
|
|
assert_template 'diff'
|
|
|
|
user.reload
|
|
|
|
assert_equal "inline", user.pref[:diff_type]
|
|
|
|
get :show, :id => 5, :type => 'sbs'
|
|
|
|
assert_response :success
|
|
|
|
assert_template 'diff'
|
|
|
|
user.reload
|
|
|
|
assert_equal "sbs", user.pref[:diff_type]
|
|
|
|
end
|
|
|
|
|
2008-06-09 22:40:59 +04:00
|
|
|
def test_show_text_file
|
|
|
|
get :show, :id => 4
|
|
|
|
assert_response :success
|
|
|
|
assert_template 'file'
|
2009-02-21 18:34:11 +03:00
|
|
|
assert_equal 'text/html', @response.content_type
|
2011-11-24 12:10:41 +04:00
|
|
|
set_tmp_attachments_directory
|
2009-02-21 18:34:11 +03:00
|
|
|
end
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2011-11-17 11:00:30 +04:00
|
|
|
def test_show_text_file_utf_8
|
2011-11-19 19:18:06 +04:00
|
|
|
set_tmp_attachments_directory
|
2011-11-17 11:00:30 +04:00
|
|
|
a = Attachment.new(:container => Issue.find(1),
|
|
|
|
:file => uploaded_test_file("japanese-utf-8.txt", "text/plain"),
|
|
|
|
:author => User.find(1))
|
|
|
|
assert a.save
|
|
|
|
assert_equal 'japanese-utf-8.txt', a.filename
|
|
|
|
|
|
|
|
str_japanese = "\xe6\x97\xa5\xe6\x9c\xac\xe8\xaa\x9e"
|
|
|
|
str_japanese.force_encoding('UTF-8') if str_japanese.respond_to?(:force_encoding)
|
|
|
|
|
|
|
|
get :show, :id => a.id
|
|
|
|
assert_response :success
|
|
|
|
assert_template 'file'
|
|
|
|
assert_equal 'text/html', @response.content_type
|
|
|
|
assert_tag :tag => 'th',
|
|
|
|
:content => '1',
|
|
|
|
:attributes => { :class => 'line-num' },
|
|
|
|
:sibling => { :tag => 'td', :content => /#{str_japanese}/ }
|
|
|
|
end
|
|
|
|
|
2011-11-20 15:46:52 +04:00
|
|
|
def test_show_text_file_replcace_cannot_convert_content
|
2011-11-19 19:18:06 +04:00
|
|
|
set_tmp_attachments_directory
|
2011-11-20 15:46:52 +04:00
|
|
|
with_settings :repositories_encodings => 'UTF-8' do
|
|
|
|
a = Attachment.new(:container => Issue.find(1),
|
|
|
|
:file => uploaded_test_file("iso8859-1.txt", "text/plain"),
|
|
|
|
:author => User.find(1))
|
|
|
|
assert a.save
|
|
|
|
assert_equal 'iso8859-1.txt', a.filename
|
|
|
|
|
|
|
|
get :show, :id => a.id
|
|
|
|
assert_response :success
|
|
|
|
assert_template 'file'
|
|
|
|
assert_equal 'text/html', @response.content_type
|
|
|
|
assert_tag :tag => 'th',
|
|
|
|
:content => '7',
|
|
|
|
:attributes => { :class => 'line-num' },
|
|
|
|
:sibling => { :tag => 'td', :content => /Demande cr\?\?e avec succ\?s/ }
|
2011-11-24 12:10:41 +04:00
|
|
|
end
|
2011-11-17 11:01:40 +04:00
|
|
|
end
|
|
|
|
|
2011-11-20 15:47:45 +04:00
|
|
|
def test_show_text_file_latin_1
|
|
|
|
set_tmp_attachments_directory
|
|
|
|
with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
|
|
|
|
a = Attachment.new(:container => Issue.find(1),
|
|
|
|
:file => uploaded_test_file("iso8859-1.txt", "text/plain"),
|
|
|
|
:author => User.find(1))
|
|
|
|
assert a.save
|
|
|
|
assert_equal 'iso8859-1.txt', a.filename
|
|
|
|
|
|
|
|
get :show, :id => a.id
|
|
|
|
assert_response :success
|
|
|
|
assert_template 'file'
|
|
|
|
assert_equal 'text/html', @response.content_type
|
|
|
|
assert_tag :tag => 'th',
|
|
|
|
:content => '7',
|
|
|
|
:attributes => { :class => 'line-num' },
|
|
|
|
:sibling => { :tag => 'td', :content => /Demande créée avec succès/ }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2009-02-21 18:34:11 +03:00
|
|
|
def test_show_text_file_should_send_if_too_big
|
2009-02-21 18:44:00 +03:00
|
|
|
Setting.file_max_size_displayed = 512
|
2009-02-21 18:34:11 +03:00
|
|
|
Attachment.find(4).update_attribute :filesize, 754.kilobyte
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2009-02-21 18:34:11 +03:00
|
|
|
get :show, :id => 4
|
|
|
|
assert_response :success
|
|
|
|
assert_equal 'application/x-ruby', @response.content_type
|
2011-11-24 12:10:41 +04:00
|
|
|
set_tmp_attachments_directory
|
2008-06-09 22:40:59 +04:00
|
|
|
end
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2008-06-09 22:40:59 +04:00
|
|
|
def test_show_other
|
|
|
|
get :show, :id => 6
|
|
|
|
assert_response :success
|
|
|
|
assert_equal 'application/octet-stream', @response.content_type
|
2011-11-24 12:10:41 +04:00
|
|
|
set_tmp_attachments_directory
|
2008-06-09 22:40:59 +04:00
|
|
|
end
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2011-04-15 17:23:13 +04:00
|
|
|
def test_show_file_from_private_issue_without_permission
|
|
|
|
get :show, :id => 15
|
|
|
|
assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2F15'
|
2011-11-24 12:10:41 +04:00
|
|
|
set_tmp_attachments_directory
|
2011-04-15 17:23:13 +04:00
|
|
|
end
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2011-04-15 17:23:13 +04:00
|
|
|
def test_show_file_from_private_issue_with_permission
|
|
|
|
@request.session[:user_id] = 2
|
|
|
|
get :show, :id => 15
|
|
|
|
assert_response :success
|
|
|
|
assert_tag 'h2', :content => /private.diff/
|
2011-11-24 12:10:41 +04:00
|
|
|
set_tmp_attachments_directory
|
2011-04-15 17:23:13 +04:00
|
|
|
end
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2012-02-17 01:00:11 +04:00
|
|
|
def test_show_file_without_container_should_be_denied
|
2012-02-20 01:42:09 +04:00
|
|
|
set_tmp_attachments_directory
|
2012-02-17 01:00:11 +04:00
|
|
|
attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
|
|
|
|
|
|
|
|
@request.session[:user_id] = 2
|
|
|
|
get :show, :id => attachment.id
|
|
|
|
assert_response 403
|
|
|
|
end
|
|
|
|
|
2012-02-23 18:39:55 +04:00
|
|
|
def test_show_invalid_should_respond_with_404
|
|
|
|
get :show, :id => 999
|
|
|
|
assert_response 404
|
|
|
|
end
|
|
|
|
|
2008-06-09 22:40:59 +04:00
|
|
|
def test_download_text_file
|
|
|
|
get :download, :id => 4
|
|
|
|
assert_response :success
|
|
|
|
assert_equal 'application/x-ruby', @response.content_type
|
2011-11-24 12:10:41 +04:00
|
|
|
set_tmp_attachments_directory
|
2008-06-09 22:40:59 +04:00
|
|
|
end
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2011-11-29 23:36:49 +04:00
|
|
|
def test_download_version_file_with_issue_tracking_disabled
|
|
|
|
Project.find(1).disable_module! :issue_tracking
|
|
|
|
get :download, :id => 9
|
|
|
|
assert_response :success
|
|
|
|
end
|
|
|
|
|
2009-12-29 16:28:30 +03:00
|
|
|
def test_download_should_assign_content_type_if_blank
|
|
|
|
Attachment.find(4).update_attribute(:content_type, '')
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2009-12-29 16:28:30 +03:00
|
|
|
get :download, :id => 4
|
|
|
|
assert_response :success
|
|
|
|
assert_equal 'text/x-ruby', @response.content_type
|
2011-11-24 12:10:41 +04:00
|
|
|
set_tmp_attachments_directory
|
2009-12-29 16:28:30 +03:00
|
|
|
end
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2009-04-25 13:31:36 +04:00
|
|
|
def test_download_missing_file
|
|
|
|
get :download, :id => 2
|
|
|
|
assert_response 404
|
2011-11-24 12:10:41 +04:00
|
|
|
set_tmp_attachments_directory
|
2009-04-25 13:31:36 +04:00
|
|
|
end
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2012-07-07 17:48:07 +04:00
|
|
|
def test_download_should_be_denied_without_permission
|
2008-07-22 21:20:02 +04:00
|
|
|
get :download, :id => 7
|
2009-01-04 21:14:51 +03:00
|
|
|
assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fdownload%2F7'
|
2011-11-24 12:10:41 +04:00
|
|
|
set_tmp_attachments_directory
|
2008-07-22 21:20:02 +04:00
|
|
|
end
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2012-07-07 17:48:07 +04:00
|
|
|
if convert_installed?
|
|
|
|
def test_thumbnail
|
|
|
|
Attachment.clear_thumbnails
|
|
|
|
@request.session[:user_id] = 2
|
|
|
|
with_settings :thumbnails_enabled => '1' do
|
|
|
|
get :thumbnail, :id => 16
|
|
|
|
assert_response :success
|
|
|
|
assert_equal 'image/png', response.content_type
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_thumbnail_should_return_404_for_non_image_attachment
|
|
|
|
@request.session[:user_id] = 2
|
|
|
|
with_settings :thumbnails_enabled => '1' do
|
|
|
|
get :thumbnail, :id => 15
|
|
|
|
assert_response 404
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_thumbnail_should_return_404_if_thumbnails_not_enabled
|
|
|
|
@request.session[:user_id] = 2
|
|
|
|
with_settings :thumbnails_enabled => '0' do
|
|
|
|
get :thumbnail, :id => 16
|
|
|
|
assert_response 404
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_thumbnail_should_return_404_if_thumbnail_generation_failed
|
|
|
|
Attachment.any_instance.stubs(:thumbnail).returns(nil)
|
|
|
|
@request.session[:user_id] = 2
|
|
|
|
with_settings :thumbnails_enabled => '1' do
|
|
|
|
get :thumbnail, :id => 16
|
|
|
|
assert_response 404
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_thumbnail_should_be_denied_without_permission
|
|
|
|
with_settings :thumbnails_enabled => '1' do
|
|
|
|
get :thumbnail, :id => 16
|
|
|
|
assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fthumbnail%2F16'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
else
|
|
|
|
puts '(ImageMagick convert not available)'
|
|
|
|
end
|
|
|
|
|
2008-12-09 19:54:46 +03:00
|
|
|
def test_destroy_issue_attachment
|
2011-11-29 22:51:39 +04:00
|
|
|
set_tmp_attachments_directory
|
2008-12-09 19:54:46 +03:00
|
|
|
issue = Issue.find(3)
|
|
|
|
@request.session[:user_id] = 2
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2008-12-09 19:54:46 +03:00
|
|
|
assert_difference 'issue.attachments.count', -1 do
|
2012-03-04 15:41:10 +04:00
|
|
|
assert_difference 'Journal.count' do
|
|
|
|
delete :destroy, :id => 1
|
|
|
|
assert_redirected_to '/projects/ecookbook'
|
|
|
|
end
|
2008-12-09 19:54:46 +03:00
|
|
|
end
|
|
|
|
assert_nil Attachment.find_by_id(1)
|
2012-03-04 15:41:10 +04:00
|
|
|
j = Journal.first(:order => 'id DESC')
|
|
|
|
assert_equal issue, j.journalized
|
2008-12-09 19:54:46 +03:00
|
|
|
assert_equal 'attachment', j.details.first.property
|
|
|
|
assert_equal '1', j.details.first.prop_key
|
|
|
|
assert_equal 'error281.txt', j.details.first.old_value
|
2012-03-04 15:41:10 +04:00
|
|
|
assert_equal User.find(2), j.user
|
2008-12-09 19:54:46 +03:00
|
|
|
end
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2008-12-09 19:54:46 +03:00
|
|
|
def test_destroy_wiki_page_attachment
|
2011-11-29 22:51:39 +04:00
|
|
|
set_tmp_attachments_directory
|
2008-12-09 19:54:46 +03:00
|
|
|
@request.session[:user_id] = 2
|
|
|
|
assert_difference 'Attachment.count', -1 do
|
2011-11-27 15:16:47 +04:00
|
|
|
delete :destroy, :id => 3
|
2008-12-09 21:00:27 +03:00
|
|
|
assert_response 302
|
|
|
|
end
|
|
|
|
end
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2008-12-09 21:00:27 +03:00
|
|
|
def test_destroy_project_attachment
|
2011-11-29 22:51:39 +04:00
|
|
|
set_tmp_attachments_directory
|
2008-12-09 21:00:27 +03:00
|
|
|
@request.session[:user_id] = 2
|
|
|
|
assert_difference 'Attachment.count', -1 do
|
2011-11-27 15:16:47 +04:00
|
|
|
delete :destroy, :id => 8
|
2008-12-09 21:00:27 +03:00
|
|
|
assert_response 302
|
|
|
|
end
|
|
|
|
end
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2008-12-09 21:00:27 +03:00
|
|
|
def test_destroy_version_attachment
|
2011-11-29 22:51:39 +04:00
|
|
|
set_tmp_attachments_directory
|
2008-12-09 21:00:27 +03:00
|
|
|
@request.session[:user_id] = 2
|
|
|
|
assert_difference 'Attachment.count', -1 do
|
2011-11-27 15:16:47 +04:00
|
|
|
delete :destroy, :id => 9
|
2008-12-09 21:00:27 +03:00
|
|
|
assert_response 302
|
2008-12-09 19:54:46 +03:00
|
|
|
end
|
|
|
|
end
|
2011-05-07 10:47:05 +04:00
|
|
|
|
2008-12-09 19:54:46 +03:00
|
|
|
def test_destroy_without_permission
|
2011-11-29 22:51:39 +04:00
|
|
|
set_tmp_attachments_directory
|
2011-11-27 15:16:47 +04:00
|
|
|
assert_no_difference 'Attachment.count' do
|
|
|
|
delete :destroy, :id => 3
|
|
|
|
end
|
|
|
|
assert_response 302
|
2008-12-09 19:54:46 +03:00
|
|
|
assert Attachment.find_by_id(3)
|
|
|
|
end
|
2008-06-09 22:40:59 +04:00
|
|
|
end
|