Commit 089fe1c1 (Optimize genex evaluation for includes and defines., 2013-02-01) introduced an optimization on DAG processing to not reprocess properties on targets which have already been seen. This was refactored slightly in commit 8dfdf1c7 (Fix the tests for evaluating includes and defines., 2013-02-18), but was not extended to cover COMPILE_OPTIONS in commit 80ca9c4b (Add COMPILE_OPTIONS target property., 2013-05-16). This omission causes the same performance regression in running cmake on LLVM which 089fe1c1 fixed before, but this time for the transitive evaluation of the COMPILE_OPTIONS property.
180 lines
5.8 KiB
C++
180 lines
5.8 KiB
C++
/*============================================================================
|
|
CMake - Cross Platform Makefile Generator
|
|
Copyright 2012 Stephen Kelly <steveire@gmail.com>
|
|
|
|
Distributed under the OSI-approved BSD License (the "License");
|
|
see accompanying file Copyright.txt for details.
|
|
|
|
This software is distributed WITHOUT ANY WARRANTY; without even the
|
|
implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
|
|
See the License for more information.
|
|
============================================================================*/
|
|
|
|
#include "cmGeneratorExpressionDAGChecker.h"
|
|
|
|
#include "cmMakefile.h"
|
|
|
|
//----------------------------------------------------------------------------
|
|
cmGeneratorExpressionDAGChecker::cmGeneratorExpressionDAGChecker(
|
|
const cmListFileBacktrace &backtrace,
|
|
const std::string &target,
|
|
const std::string &property,
|
|
const GeneratorExpressionContent *content,
|
|
cmGeneratorExpressionDAGChecker *parent)
|
|
: Parent(parent), Target(target), Property(property),
|
|
Content(content), Backtrace(backtrace)
|
|
{
|
|
const cmGeneratorExpressionDAGChecker *top = this;
|
|
const cmGeneratorExpressionDAGChecker *p = this->Parent;
|
|
while (p)
|
|
{
|
|
top = p;
|
|
p = p->Parent;
|
|
}
|
|
this->CheckResult = this->checkGraph();
|
|
|
|
if (CheckResult == DAG && (top->EvaluatingIncludeDirectories()
|
|
|| top->EvaluatingCompileDefinitions()
|
|
|| top->EvaluatingCompileOptions()))
|
|
{
|
|
std::map<cmStdString, std::set<cmStdString> >::const_iterator it
|
|
= top->Seen.find(target);
|
|
if (it != top->Seen.end())
|
|
{
|
|
const std::set<cmStdString> &propSet = it->second;
|
|
const std::set<cmStdString>::const_iterator i = propSet.find(property);
|
|
if (i != propSet.end())
|
|
{
|
|
this->CheckResult = ALREADY_SEEN;
|
|
return;
|
|
}
|
|
}
|
|
const_cast<cmGeneratorExpressionDAGChecker *>(top)
|
|
->Seen[target].insert(property);
|
|
}
|
|
}
|
|
|
|
//----------------------------------------------------------------------------
|
|
cmGeneratorExpressionDAGChecker::Result
|
|
cmGeneratorExpressionDAGChecker::check() const
|
|
{
|
|
return this->CheckResult;
|
|
}
|
|
|
|
//----------------------------------------------------------------------------
|
|
void cmGeneratorExpressionDAGChecker::reportError(
|
|
cmGeneratorExpressionContext *context,
|
|
const std::string &expr)
|
|
{
|
|
if (this->CheckResult == DAG)
|
|
{
|
|
return;
|
|
}
|
|
|
|
context->HadError = true;
|
|
if (context->Quiet)
|
|
{
|
|
return;
|
|
}
|
|
|
|
const cmGeneratorExpressionDAGChecker *parent = this->Parent;
|
|
|
|
if (parent && !parent->Parent)
|
|
{
|
|
cmOStringStream e;
|
|
e << "Error evaluating generator expression:\n"
|
|
<< " " << expr << "\n"
|
|
<< "Self reference on target \""
|
|
<< context->HeadTarget->GetName() << "\".\n";
|
|
context->Makefile->GetCMakeInstance()
|
|
->IssueMessage(cmake::FATAL_ERROR, e.str().c_str(),
|
|
parent->Backtrace);
|
|
return;
|
|
}
|
|
|
|
{
|
|
cmOStringStream e;
|
|
e << "Error evaluating generator expression:\n"
|
|
<< " " << expr << "\n"
|
|
<< "Dependency loop found.";
|
|
context->Makefile->GetCMakeInstance()
|
|
->IssueMessage(cmake::FATAL_ERROR, e.str().c_str(),
|
|
context->Backtrace);
|
|
}
|
|
|
|
int loopStep = 1;
|
|
while (parent)
|
|
{
|
|
cmOStringStream e;
|
|
e << "Loop step " << loopStep << "\n"
|
|
<< " "
|
|
<< (parent->Content ? parent->Content->GetOriginalExpression() : expr)
|
|
<< "\n";
|
|
context->Makefile->GetCMakeInstance()
|
|
->IssueMessage(cmake::FATAL_ERROR, e.str().c_str(),
|
|
parent->Backtrace);
|
|
parent = parent->Parent;
|
|
++loopStep;
|
|
}
|
|
}
|
|
|
|
//----------------------------------------------------------------------------
|
|
cmGeneratorExpressionDAGChecker::Result
|
|
cmGeneratorExpressionDAGChecker::checkGraph() const
|
|
{
|
|
const cmGeneratorExpressionDAGChecker *parent = this->Parent;
|
|
while (parent)
|
|
{
|
|
if (this->Target == parent->Target && this->Property == parent->Property)
|
|
{
|
|
return (parent == this->Parent) ? SELF_REFERENCE : CYCLIC_REFERENCE;
|
|
}
|
|
parent = parent->Parent;
|
|
}
|
|
return DAG;
|
|
}
|
|
|
|
//----------------------------------------------------------------------------
|
|
bool cmGeneratorExpressionDAGChecker::EvaluatingLinkLibraries()
|
|
{
|
|
const cmGeneratorExpressionDAGChecker *top = this;
|
|
const cmGeneratorExpressionDAGChecker *parent = this->Parent;
|
|
while (parent)
|
|
{
|
|
top = parent;
|
|
parent = parent->Parent;
|
|
}
|
|
|
|
const char *prop = top->Property.c_str();
|
|
return (strcmp(prop, "LINK_LIBRARIES") == 0
|
|
|| strcmp(prop, "LINK_INTERFACE_LIBRARIES") == 0
|
|
|| strcmp(prop, "IMPORTED_LINK_INTERFACE_LIBRARIES") == 0
|
|
|| strncmp(prop, "LINK_INTERFACE_LIBRARIES_", 25) == 0
|
|
|| strncmp(prop, "IMPORTED_LINK_INTERFACE_LIBRARIES_", 34) == 0);
|
|
}
|
|
|
|
//----------------------------------------------------------------------------
|
|
bool cmGeneratorExpressionDAGChecker::EvaluatingIncludeDirectories() const
|
|
{
|
|
const char *prop = this->Property.c_str();
|
|
return (strcmp(prop, "INCLUDE_DIRECTORIES") == 0
|
|
|| strcmp(prop, "INTERFACE_INCLUDE_DIRECTORIES") == 0 );
|
|
}
|
|
|
|
//----------------------------------------------------------------------------
|
|
bool cmGeneratorExpressionDAGChecker::EvaluatingCompileDefinitions() const
|
|
{
|
|
const char *prop = this->Property.c_str();
|
|
return (strcmp(prop, "COMPILE_DEFINITIONS") == 0
|
|
|| strcmp(prop, "INTERFACE_COMPILE_DEFINITIONS") == 0
|
|
|| strncmp(prop, "COMPILE_DEFINITIONS_", 20) == 0);
|
|
}
|
|
|
|
//----------------------------------------------------------------------------
|
|
bool cmGeneratorExpressionDAGChecker::EvaluatingCompileOptions() const
|
|
{
|
|
const char *prop = this->Property.c_str();
|
|
return (strcmp(prop, "COMPILE_OPTIONS") == 0
|
|
|| strcmp(prop, "INTERFACE_COMPILE_OPTIONS") == 0 );
|
|
}
|