Commit Graph

177 Commits

Author SHA1 Message Date
Brad King acd8161bad ccmake: Remove extra parens around comparison
The Clang compiler warns about extra parenthesis in the code

  if ((form->curpage == field->page))
      ~              ^             ~

because the idiom is commonly used when an assignment is intended
instead of a comparison.  Remove the extra enclosing layer.
2011-02-15 08:46:50 -05:00
Brad King 182eb7c7ef Merge topic 'dev/strict-mode'
dd2f814 Merge branch 'dev/add_test-working-directory' into dev/strict-mode
949d32c Unwatch manual variables upon removal in cmake-gui
3939032 Unwatch manual variables upon removal in ccmake
8354413 Add method to unwatch a manual variable
8ed3c85 Give a better message for unused variables
729db48 Fix ArgumentExpansion test expected results
89c2544 Checking for a definition is a usage
5625dee Don't output to stderr in the GUI
ad25a96 Merge branch 'ImprovedDotSupport2' into dev/strict-mode
c128abe Merge branch 'AddCMAKE_CURRENT_LIST_DIR' into dev/strict-mode
9bcaff0 Merge branch 'cmake-guiRememberAdvancedCheckbox' into dev/strict-mode
544d0c3 Fix expected output for WarnUninitialized test
4e3bea4 Update expected messages to new format
8e8c9e4 Don't check at destruction for usage
668e005 Use cmake::IssueMessage for warnings
88cd4c1 Use 'CMake Warning' versus 'warning' for CDash
3c3b98d Initialize the class before setting warn flags
cf8b15a Ignore files under the CMakeFiles directory
fd50f06 Don't check for unused vars at configure time
447a04c Don't warn during configure when doing everything
b97ee21 Check for unused variables at the end of generate
c18c977 When checking for variables, specify a reason
3f1121f Use a long int since Line is a long as well
2507f93 Change the failure case string to 'Unexpected'
fe390a2 Add 'ArgumentExpansion' test
8dbb209 Wrong boolean value for CLI warnings
d4ee998 Hard-code the --no-warn-unused-cli flag
a267b99 Fix line lengths
82ed104 Flag that the directories have been set
5aa535b Add argument to arg parsing to not set directories
367e5c3 Revert "Revert "When calling CMake, set the args and the cache""
ab5d4e4 Revert "When calling CMake, set the args and the cache"
9b90040 When calling CMake, set the args and the cache
fe56002 Fix long lines for KWStyle
5d30cfc Set a watch on variables added through the gui
33c63b1 Add a method to put a watch for variables
535253f Initialize the warning variables earlier
cbb286c Fix the path detection to work for top-level
62be1f7 Initialize the usage stack earlier
c6e7fab Factor out the checks for unused variables
5e41ba8 When using the API, check for Add vs. Remove
dee1976 Fix typo in VariableUnusedViaUnset test
f231ce5 Remove old false positive avoidance code
a117e02 Revert "Add test for unused warnings at the end of scope"
2c82f2b Exempt CMAKE(CURRENT|PARENT)_LIST_FILE from usage
6d7d449 Ignore CLI warnings for ABI determination
7740a73 Only return local keys that are defined
bef3aee Use the API so that warnings can be tracked
05cb0f4 Check for unused variables in the dtor
91c4c99 Add test for unused warnings at the end of scope
ca90f67 Fix detection of unused variables when setting
f7438ca Add test for unused detection via setting it
995cfb0 Don't warn if the variable wasn't defined
aefc91d Add test for usage checks via unset
a8e97f8 Remove VarRemoved code since it's been superceded
59463ef Rework CheckVariableForUnused usage
f117423 Fix line lengths to be no more than 78
e49a935 Improve unused warning logic
e01e40c Mark ARGC, ARGV*, and ARGN as used
a17aff7 Ignore CMAKE_MATCH_* variables for usage
02a114d Add method to allow variables to be marked as used
a0b0d23 CMAKE_DO_TRY_COMPILE is no longer used
ae3eff3 Fix the path used for ignoring system warnings
056b441 Fix missing case for usage of a variable
980e048 Factor out checks for unused variables
83acb0a Remove now unused variables
3801463 Use built-ins for readability and maintainability
8b52015 Push the initialize and unused states when copying
439877f Be consistent with single and double quotes
4cf1706 Add documentation for check-system-vars
b74777f Fix the spelling of the flag for warn-unused-vars
b948120 Change logic of flag to turn off cli unused checks
f047a17 Add test for uninitialized variables
75bda38 Add tests for unused command line variables
300fc15 Fix detection of system files
d784e6a Run the unused variables check on the final pass
9efc057 VariableWatch is not available when bootstrapping
2e78224 Add a missing comma to the warning message
7499700 Add a flag to warn about system files
fff9f6d Rename flags again and use variablewatch for cli
786e269 Add warn-unused to the Qt interface
636e6c4 Default to marking things as used
4ff0340 Rename find-unused to warn-unused
d7999e9 Rename strict-mode to warn-uninitialized
e141bc9 Detect unused variables
d3e8eb5 Add flags to detect unused variables
f332e14 Complete strict-mode checks for uninitialized vars
52f9637 Add method to get the local scope variables
f794d58 Make --strict-mode option, and integrate with cmake-gui
48b5b85 Add a warning when variables are used uninitialized.
cd626ea For macros make sure the FilePath points to a valid pointer in the args.
2011-01-27 15:34:07 -05:00
David Cole 693c9a6236 Avoid exceptions when ccmake terminal window is too small (#11668)
Thanks to Nicolas Despres for the patch.
2011-01-19 11:24:36 -05:00
Ben Boeckel 393903218d Unwatch manual variables upon removal in ccmake 2011-01-13 17:58:23 -05:00
Brad King dde0c89cfc ccmake: Use LSB 4.0 getmaxyx conditionally
Use of 'getmaxyx' works on LSB but does not seem portable to other
curses versions.
2011-01-05 11:07:24 -05:00
Brad King a3de30eed9 ccmake: Use LSB 4.0 curses API conditionally
Use of 'attr_t' and 'wattr_get' works on LSB but does not seem
portable to other curses versions.
2011-01-04 08:52:50 -05:00
Craig Scott 7d691cab9b ccmake: Port for LSB 4.0 (#11648)
Use getmaxyx instead of getmax[xy].  Avoid using getattrs.
2011-01-03 12:15:41 -05:00
Brad King 9da64e7c6b Merge topic 'fix-ccmake-search'
5d7c3c0 ccmake: Fix search with '/'
2010-09-21 10:33:08 -04:00
Brad King 5d7c3c0a59 ccmake: Fix search with '/'
Commit 7a18dd8e (Add searching of variables, 2003-03-07) added method
cmCursesMainForm::JumpToCacheEntry to search for cache entries whose
names match a given search string.  The method also had a useless
argument "int idx" probably left from earlier development iterations and
hard-coded in all calls to the value '-1'.  The method compared this
argument to the "NumberOfVisibleEntries" member which at the time was of
type "int" also.

Commit ff1f8d0b (Fix or cast more integer conversions in cmake,
2010-06-29) changed the type of "NumberOfVisibleEntries" to size_t to
fix other integer conversion warnings.  An unsigned type makes sense
given the purpose of the member.  However, this caused the '-1' signed
value to be converted to a large unsigned value in the above-mentioned
comparison, leading to incorrect behavior.

Fix the problem by removing the useless argument and the comparison.
2010-09-16 17:45:27 -04:00
Brad King e1a4c02bac Merge topic 'resolve/doc-spelling/CPackRPM'
7739d78 Merge CPackRPM changes into doc-spelling
9203e91 Fix spelling errors reported by Lintian.
2010-07-20 16:00:29 -04:00
Kai Wasserbäch 9203e9187e Fix spelling errors reported by Lintian.
During a Lintian run on the binary packages of CMake in Debian I was
notified of many spelling mistakes.
2010-07-13 09:41:37 -04:00
Brad King fec71d8016 Fix signed/unsigned comparison warnings in ccmake
Commit ff1f8d0b (Fix or cast more integer conversions in cmake) changed
a member type from int to size_t.  Update the types of variables
compared to these values to be unsigned also.
2010-06-29 11:09:36 -04:00
Brad King ff1f8d0b53 Fix or cast more integer conversions in cmake
These were revealed by GCC's -Wconversion option.  Fix types where it is
easy to do so.  Cast in cases we know the integer will not be truncated.
2010-06-29 09:52:12 -04:00
David Cole 44bcba7461 Fix warnings in CMake source code. Suppress rampant warnings emanating from Qt files. 2009-10-01 16:47:08 -04:00
Brad King 96afb12087 Convert CMake to OSI-approved BSD License
This converts the CMake license to a pure 3-clause OSI-approved BSD
License.  We drop the previous license clause requiring modified
versions to be plainly marked.  We also update the CMake copyright to
cover the full development time range.
2009-09-28 11:43:28 -04:00
Brad King b41a548d86 Add parentheses around '&&' between '||' for gcc
The GNU compiler warns about possible operator precedence mistakes and
asks for explicit parentheses (-Wparentheses).  We add the parentheses
to silence the warning.  This also fixes one real logic error in the
find_package() implementation by correcting expression evaluation order.
2009-09-11 08:18:15 -04:00
Brad King 98c51ff6dc ENH: Overhaul CMake version numbering
This moves the version numbers into an isolated configured header so
that not all of CMake needs to rebuild when the version changes.

Previously we had spaces, dashes and/or the word 'patch' randomly chosen
before the patch number.  Now we always report version numbers in the
traditional format "<major>.<minor>.<patch>[-rc<rc>]".

We still use odd minor numbers for development versions.  Now we also
use the CCYYMMDD date as the patch number of development versions, thus
allowing tests for exact CMake versions.
2009-03-05 15:17:07 -05:00
Bill Hoffman f0a41ce160 BUG: fix for 4026, display a message if ccmake has errors 2008-10-09 12:49:49 -04:00
Bill Hoffman b3b4350879 BUG: fix for 6462, delete key should delete the current char 2008-08-19 16:40:19 -04:00
Bill Hoffman 354abb72d9 ENH: fix it for working with an empty cache 2008-03-07 16:32:09 -05:00
Bill Hoffman 3fa087c8ab ENH: fix make edit_cache for cmake-gui 2008-02-12 09:49:42 -05:00
Brad King f5a5b1ffd6 ENH: Simplify code by removing unnecessary LINK_DIRECTORIES call. 2008-01-23 16:53:33 -05:00
Brad King 9f61e2a235 ENH: Centralized and globalized computation of CMake program locations. This eliminates startup paths that failed to produce this information. 2007-12-13 17:56:50 -05:00
Ken Martin 6cdf032505 ENH: change to make the documentation class more generic, about halfway there, also provides secitons for Variables now 2007-10-22 12:49:09 -04:00
Alexander Neundorf c41f798383 COMP: make it build on NetBSD, which has separate curses and ncurses, so
it has to be detected that curses isn't good enough, but ncurses is, and
that ncurses.h instead of curses.h is included

Alex
2007-08-27 09:01:14 -04:00
Alexander Neundorf c95dc91237 ENH:
-in the full documentation there is now an extra section for
compatibility commands, so users see which commands they shouldn't use
-cmake -h <command> now also works with lower case commands
--help-fullm --help-command, --help-module and --help-property now determine
the output format from the extension of the given filename

Let me know if there are some things I overlooked.

Alex
2007-06-28 11:00:57 -04:00
Bill Hoffman e2a7c9358f ENH: fix warning 2006-11-29 17:25:46 -05:00
Bill Hoffman 33170bc371 ENH: there can be only one version 2006-11-29 17:17:16 -05:00
Ken Martin f7217ef344 ENH: remove old unused code 2006-10-06 15:33:16 -04:00
Brad King 9e709f6bde BUG: The --help option should list generators. This addresses bug #2494. 2006-10-04 19:21:20 -04:00
Bill Hoffman 65e3842d51 ENH: only change the cache if the value was really changed 2006-08-10 11:05:44 -04:00
Bill Hoffman 88e3cd53ab ENH: fix ia64 build with aCC 2006-06-27 09:57:02 -04:00
Bill Hoffman e975836292 ENH: not all messages are errors 2006-03-16 11:28:13 -05:00
Ken Martin fb5d92ea37 ENH: m_ cleanup for curses 2006-03-16 10:44:55 -05:00
Bill Hoffman e4894bfc91 ENH: add curses include directory 2005-07-11 18:07:02 -04:00
Andy Cedilnik b17c77a1b5 ENH: Until there is some test for curses dialog, no need to do coverage 2005-06-20 17:37:40 -04:00
Brad King c7a75e92c9 COMP: Changed while(1) to for(;;) to avoid warning about constant control expression. 2005-05-03 14:57:32 -04:00
Brad King d6d91ac89f ENH: Removing stdio_core hack. A better work-around has been put in cmStandardIncludes.h. 2005-04-26 14:12:31 -04:00
Brad King e26bafa52a BUG: Older SGI compilers still have internal/stdio_core.h but do not support #include_next. We'll have to try-compile to test whether this hack is needed. 2005-04-24 13:15:50 -04:00
Brad King 2f4e516e23 COMP: Using a new work-around for stdarg.h problem on SGI. 2005-04-21 17:00:36 -04:00
Andy Cedilnik 1e04844de9 COMP: Attempt to fix problem with building on SGI 2005-04-19 18:26:40 -04:00
Andy Cedilnik 21c818340e STYLE: Remove unused code 2004-10-27 10:45:45 -04:00
Andy Cedilnik 3bc8cbd475 ENH: Reload PreLoad.cmake every time you do configure 2004-08-17 16:13:31 -04:00
Andy Cedilnik c4805a1b79 ENH: Enable preload for ccmake 2004-08-17 15:36:28 -04:00
Bill Hoffman 2474302c25 ENH: remove deletes 2004-07-20 11:02:12 -04:00
Bill Hoffman 9fe2ab2f71 BUG: fix for 981 cursor returns to correct place in help screen 2004-07-19 13:01:40 -04:00
Brad King 4eb0400c98 ENH: Adding MODIFIED property to cache values that have been changed by the user. 2004-06-23 10:13:02 -04:00
Andy Cedilnik 685be51a0e ENH: Add support for HOME and END keys. Also fix Bug #666 - In CCMake when deleting something, it does not stop at the beginning of line 2004-04-15 16:11:11 -04:00
Andy Cedilnik 0986b42761 BUG: Prevent deleting not existing variables and therefore prevent crash. Fixes: Bug #750 - CCMake crashes when deleting all variables 2004-04-15 15:46:58 -04:00
Andy Cedilnik 183273bea2 BUG: Prevent crash when deleting the last cache item 2004-02-22 22:06:33 -05:00