Commit Graph

23 Commits

Author SHA1 Message Date
Brad King c4275592a8 Modules: Include builtin FindPackageHandleStandardArgs directly
The FindPackageHandleStandardArgs module was originally created outside
of CMake.  It was added for CMake 2.6.0 by commit e118a627 (add a macro
FIND_PACKAGE_HANDLE_STANDARD_ARGS..., 2007-07-18).  However, it also
proliferated into a number of other projects that at the time required
only CMake 2.4 and thus could not depend on CMake to provide the module.
CMake's own find modules started using the module in commit b5f656e0
(use the new FIND_PACKAGE_HANDLE_STANDARD_ARGS in some of the FindXXX
modules..., 2007-07-18).

Then commit d358cf5c (add 2nd, more powerful mode to
find_package_handle_standard_args, 2010-07-29) added a new feature to
the interface of the module that was fully optional and backward
compatible with all existing users of the module.  Later commit 5f183caa
(FindZLIB: use the FPHSA version mode, 2010-08-04) and others shortly
thereafter started using the new interface in CMake's own find modules.
This change was also backward compatible because it was only an
implementation detail within each module.

Unforutnately these changes introduced a problem for projects that still
have an old copy of FindPackageHandleStandardArgs in CMAKE_MODULE_PATH.
When any such project uses one of CMake's builtin find modules the line

  include(FindPackageHandleStandardArgs)

loads the copy from the project which does not have the new interface!
Then the including find module tries to use the new interface with the
old module and fails.

Whether this breakage can be considered a backward incompatible change
in CMake is debatable.  The situation is analagous to copying a standard
library header from one version of a compiler into a project and then
observing problems when the next version of the compiler reports errors
in its other headers that depend on its new version of the original
header.  Nevertheless it is a change to CMake that causes problems for
projects that worked with previous versions.

This problem was discovered during the 2.8.3 release candidate cycle.
It is an instance of a more general problem with projects that provide
their own versions of CMake modules when other CMake modules depend on
them.  At the time we resolved this instance of the problem with commit
b0118402 (Use absolute path to FindPackageHandleStandardArgs.cmake
everywhere, 2010-09-28) for the 2.8.3 release.

In order to address the more general problem we introduced policy
CMP0017 in commit db44848f (Prefer files from CMAKE_ROOT when including
from CMAKE_ROOT, 2010-11-17).  That change was followed by commit
ce28737c (Remove usage of CMAKE_CURRENT_LIST_DIR now that we have
CMP0017, 2010-12-20) which reverted the original workaround in favor of
using the policy.  However, existing project releases do not set the
policy behavior to NEW and therefore still exhibit the problem.

We introduced in commit a364daf1 (Allow users to specify defaults for
unset policies, 2011-01-03) an option for users to build existing
projects by adding -DCMAKE_POLICY_DEFAULT_CMP0017=NEW to the command
line.  Unfortunately this solution still does not allow such projects to
build out of the box, and there is no good way to suggest the use of the
new option.

The only remaining solution to keep existing projects that exhibit this
problem building is to restore the change originally made in commit
b0118402 (Use absolute path to FindPackageHandleStandardArgs.cmake
everywhere, 2010-09-28).  This also avoids policy CMP0017 warnings for
this particular instance of the problem the policy addresses.
2011-01-20 10:56:49 -05:00
Alex Neundorf ce28737c93 Remove usage of CMAKE_CURRENT_LIST_DIR now that we have CMP0017
This puts the new search behaviour for included files in action, i.e.
now when a file from Modules/ include()s another file, it also gets the
one from Modules/ included, i.e. the one it expects.

Alex
2011-01-04 08:20:08 -05:00
Alex Neundorf b01184022b Use absolute path to FindPackageHandleStandardArgs.cmake everywhere
This is to avoid getting an (older) copy of FPHSA.cmake which is
e.g. installed with KDE 4.5.0 and 4.5.1.

Alex
2010-09-28 22:30:31 +02:00
Todd Gamblin 2cde67a781 Modules: Fix spelling 'To distributed' -> 'To distribute' 2010-08-09 08:48:31 -04:00
Brad King c4bb9c9d42 Convert CMake find-modules to BSD License
This adds copyright/license notification blocks CMake's find-modules.
Many of the modules had no notices at all.  Some had notices referring
to the BSD license already.  This commit normalizes existing notices and
adds missing notices.
2009-09-28 11:45:50 -04:00
Philip Lowman 1569f5d0e4 BUG: Fix other modules not respecting QUIET and REQUIRED 2009-01-30 15:13:07 -05:00
Philip Lowman 6f000b55c9 STYLE: Reworded some of the OS-X code comments 2009-01-28 22:56:38 -05:00
Philip Lowman 47588ac8d0 BUG: Fixes Issue #8054 and more. DOXYGEN_DOT_FOUND now exists, errant
mark_as_advanced variables removed, documentation cleaned up and OSX stuff
isolated to it's own section, support added for DOXYGEN_SKIP_DOT, support
added to call FindPackageHandleStandardArgs to avoid output on every CMake
run.
2009-01-19 22:28:09 -05:00
David Cole b77d00b7f6 ENH: New location to look for "dot" 2008-12-26 12:06:38 -05:00
Bill Hoffman 3b1c74d34a ENH: fix for backwards compatibility 2006-12-04 19:37:29 -05:00
Bill Hoffman 273ac87571 BUG: fix for bug 4102 2006-12-04 11:52:46 -05:00
Bill Hoffman 112dadc0e8 ENH: fix more doxygen issues 2006-10-24 10:03:58 -04:00
Bill Hoffman 2e3eebc20a ENH: put in backwards compatibility for older cmake 2006-10-23 14:51:56 -04:00
Bill Hoffman 641a0ad878 BUG: fix for bug# 3310 2006-10-16 10:47:18 -04:00
Bill Hoffman 4fc95339f7 ENH: remove paths that cmake already looks at 2006-10-04 16:31:00 -04:00
Bill Hoffman 7ed0532ae9 BUG: fix for bug#3520 - better find doxygen 2006-10-04 11:04:26 -04:00
Bill Hoffman 7603244509 ENH: use program files env for searching 2006-02-28 10:27:30 -05:00
Bill Hoffman b7fa820118 ENH: add documentation support for modules 2005-12-14 13:51:08 -05:00
Bill Hoffman 6d37630770 ENH: fix for darwin from eric wing 2005-07-13 09:08:47 -04:00
Sebastien Barre 6037cc8b3b a) new version of tools like Doxygen and Graphviz now set install path info in win32 registery. use it.
b) remove DOT_PATH, it was polluting the cache (can be computed from DOT, update CMakeLists.txt accordingly if DOT_PATH is not defined)
2004-06-08 17:26:48 -04:00
Sebastien Barre cb4f04c94e Remove unneeded test and code duplication. Add WIN32 test. Make all ADVANCED. 2001-12-04 10:55:17 -05:00
Sebastien Barre 10c54eb2a5 Find Graphivz's dot too 2001-10-23 17:47:32 -04:00
Sebastien Barre a9e376de1d Add Doxygen and Wget modules. Very simple. But might be more complex later, so let's use them asap 2001-10-23 17:06:19 -04:00