7f6b8d3399
Simplify boolean expressions
...
Use clang-tidy's readability-simplify-boolean-expr checker.
After applying the fix-its, revise all changes *very* carefully.
Be aware of false positives and invalid changes.
2016-06-02 08:24:04 -04:00
618fb23fc9
Pass arguments that are not modified as const&.
...
Use clang-tidy's performance-unnecessary-value-param checker to find
value parameter declarations of expensive to copy types that are not
modified inside the function. Ignore findings in kwsys.
After applying the fix-its, manually change `const T&` to `T const&`.
2016-05-26 21:58:51 +02:00
d9fd2f5402
Revise C++ coding style using clang-format
...
Run the `Utilities/Scripts/clang-format.bash` script to update
all our C++ code to a new style defined by `.clang-format`.
Use `clang-format` version 3.8.
* If you reached this commit for a line in `git blame`, re-run the blame
operation starting at the parent of this commit to see older history
for the content.
* See the parent commit for instructions to rebase a change across this
style transition commit.
2016-05-16 16:05:19 -04:00
0ac18d40c8
Remove `//------...` horizontal separator comments
...
Modern editors provide plenty of ways to visually separate functions.
Drop the explicit comments that previously served this purpose.
Use the following command to automate the change:
$ git ls-files -z -- \
"*.c" "*.cc" "*.cpp" "*.cxx" "*.h" "*.hh" "*.hpp" "*.hxx" |
egrep -z -v "^Source/cmCommandArgumentLexer\." |
egrep -z -v "^Source/cmCommandArgumentParser(\.y|\.cxx|Tokens\.h)" |
egrep -z -v "^Source/cmDependsJavaLexer\." |
egrep -z -v "^Source/cmDependsJavaParser(\.y|\.cxx|Tokens\.h)" |
egrep -z -v "^Source/cmExprLexer\." |
egrep -z -v "^Source/cmExprParser(\.y|\.cxx|Tokens\.h)" |
egrep -z -v "^Source/cmFortranLexer\." |
egrep -z -v "^Source/cmFortranParser(\.y|\.cxx|Tokens\.h)" |
egrep -z -v "^Source/cmListFileLexer\." |
egrep -z -v "^Source/cm_sha2" |
egrep -z -v "^Source/(kwsys|CursesDialog/form)/" |
egrep -z -v "^Utilities/(KW|cm).*/" |
xargs -0 sed -i '/^\(\/\/---*\|\/\*---*\*\/\)$/ {d;}'
This avoids modifying third-party sources and generated sources.
2016-05-09 09:41:43 -04:00
270eb96df0
strings: Remove cmStdString references
...
Casts from std::string -> cmStdString were high on the list of things
taking up time. Avoid such implicit casts across function calls by just
using std::string everywhere.
The comment that the symbol name is too long is no longer relevant since
modern debuggers alias the templates anyways and the size is a
non-issue since the underlying methods are generated since it's
inherited.
2014-03-08 13:05:35 -05:00
310ef08fed
stringapi: Use strings for source names
2014-03-08 13:05:29 -05:00
5cc9fb0234
cmSourceGroup: Fix method name capitalization.
...
Adhere to the dominant style.
2014-01-22 15:16:40 +01:00
fe8b0330eb
cmMakefile: Constify some cmSourceGroup related code.
2014-01-22 15:16:40 +01:00
00e96808aa
CMake: source_group needs to check its own regex after its children ( #13611 )
...
Otherwise, regexes that descend into sub-folders do not get grouped correctly.
2012-11-23 10:57:13 -05:00
7bbaa4283d
Remove trailing whitespace from most CMake and C/C++ code
...
Our Git commit hooks disallow modification or addition of lines with
trailing whitespace. Wipe out all remnants of trailing whitespace
everywhere except third-party code.
Run the following shell code:
git ls-files -z -- \
bootstrap doxygen.config '*.readme' \
'*.c' '*.cmake' '*.cpp' '*.cxx' \
'*.el' '*.f' '*.f90' '*.h' '*.in' '*.in.l' '*.java' \
'*.mm' '*.pike' '*.py' '*.txt' '*.vim' |
egrep -z -v '^(Utilities/cm|Source/(kwsys|CursesDialog/form)/)' |
egrep -z -v '^(Modules/CPack\..*\.in)' |
xargs -0 sed -i 's/ \+$//'
2012-08-13 14:18:39 -04:00
46f4940675
Remove unused cmSourceGroup method
...
The non-const GetSourceFiles method is not needed.
2012-03-09 15:16:03 -05:00
96afb12087
Convert CMake to OSI-approved BSD License
...
This converts the CMake license to a pure 3-clause OSI-approved BSD
License. We drop the previous license clause requiring modified
versions to be plainly marked. We also update the CMake copyright to
cover the full development time range.
2009-09-28 11:43:28 -04:00
28b1912aa3
ENH: add group support and fix borland error
2009-07-11 00:05:20 -04:00
10db44a81d
COMP: Fix build with concept checking of STL.
...
- Fix cmSourceGroup to not use std::vector with an incomplete type.
2008-05-16 16:56:41 -04:00
9220e97401
BUG: fix #4057 (which had several duplicates): handle recursivew source groups better, i.e. multiple sourcegroups with the same end component work now
...
Alex
2007-08-24 14:21:49 -04:00
3d96e52261
STYLE: some m_ to this-> cleanup
2006-03-15 11:02:08 -05:00
aa47caab2d
FIX: apply patch from bug# 1965
2005-07-13 11:21:30 -04:00
48aedb2ba3
ENH: Fully implemented SOURCE_GROUP command.
2003-07-23 15:32:54 -04:00
0b3b21fa63
warning fixes
2003-06-03 14:55:20 -04:00
ba68f771b3
yikes added new custom command support
2003-06-03 10:30:23 -04:00
3893ee72d2
Add comment support, so that you can see in build process what the custom command does
2002-12-10 16:47:37 -05:00
1f6a3c67b1
ENH: Added reference to Copyright.txt. Removed old reference to ITK copyright. Changed program name to CMake instead of Insight in source file header. Also removed tabs.
2002-10-23 18:03:27 -04:00
809b32fe59
ENH: remove several compiler warnings
2002-03-13 10:25:11 -05:00
076aafe79a
ENH: add file specific compile flags
2002-03-04 14:14:41 -05:00
a6a43d5320
ENH:Updated copyright
2002-01-21 15:30:43 -05:00
cc5c1fa6f7
ENH: separate command from its arguments in the custom command. This allows the generator on windows to change the slashes for just the command
2001-09-04 16:07:54 -04:00
de10cfc72e
ENH: move testing stuff to cmake from configure, good bye dashboard... :)
2001-05-04 11:30:46 -04:00
4d9b2f59cc
better custom rules
2001-05-04 09:39:05 -04:00
2f42d7ffcb
BUG: Removed output of dual rules for source files that are processed by both the compiler and by a custom command. Also removed generation of duplicate CMakeLists.txt in the project files.
2001-04-27 14:51:43 -04:00
54cfe84f3f
ENH:New copyright
2001-04-27 08:01:17 -04:00
24bce99cbf
cleaned up the coding style made ivars private etc
2001-04-19 13:28:46 -04:00
865ec96644
major changes to support multiple libraries and source lists
2001-04-11 14:59:02 -04:00
8c087d0e7a
ENH: Added SOURCE_GROUP command and corresponding support code. This command allows CMakeLists files to specify how sources are organized into groups in the generated DSP files and makefiles.
2001-03-20 13:20:59 -05:00
Daniel Pfeifer
Kitware Robot
Brad King
Ben Boeckel
Stephen Kelly
Clemens Heppner
Bill Hoffman
Alexander Neundorf
Ken Martin
Andy Cedilnik
Will Schroeder