CMake

Commit Graph

Author	SHA1	Message	Date
Daniel Pfeifer	3f77655d06	CM_OVERRIDE: fix feature test for clang Clang refuses to default initialize an instance of a class that does not have a default constructor. Fix the check by adding default constructors. Don't use brace initialization like it is proposed in the error message. We want to test the override support independent from the support for brace initialization.	2016-06-29 11:33:38 +02:00
Daniel Pfeifer	9e2d6f0c4d	CM_OVERRIDE: mark destructor overridden in the feature test. This is important for two reasons: 1. A compiler might warn about a class that has a virtual member function but no virtual destructor. We don't want to treat the feature as incomplete in this case. 2. MSVC10 supports the override identifier except on destructors. In this case, the feature really is incomplete and we want to detect it as such.	2016-06-27 23:24:09 +02:00
Daniel Pfeifer	5286110d6f	cxx features: add check for override	2016-06-27 10:37:41 -04:00

Author

SHA1

Message

Date

Daniel Pfeifer

3f77655d06

CM_OVERRIDE: fix feature test for clang

Clang refuses to default initialize an instance of a class that does not
have a default constructor.  Fix the check by adding default
constructors.  Don't use brace initialization like it is proposed in the
error message.  We want to test the override support independent from
the support for brace initialization.

2016-06-29 11:33:38 +02:00

Daniel Pfeifer

9e2d6f0c4d

CM_OVERRIDE: mark destructor overridden in the feature test.

This is important for two reasons:

1. A compiler might warn about a class that has a virtual member
function but no virtual destructor.  We don't want to treat the feature
as incomplete in this case.

2. MSVC10 supports the override identifier except on destructors.  In
this case, the feature really is incomplete and we want to detect it as
such.

2016-06-27 23:24:09 +02:00

Daniel Pfeifer

5286110d6f

cxx features: add check for override

2016-06-27 10:37:41 -04:00

3 Commits