Commit Graph

57 Commits

Author SHA1 Message Date
Brad King 4c88a8622d KWSys: Avoid buffer overflow in SystemInformation (#11018)
Use std::string instead of fixed-size char arrays.

Author: Ben Boeckel <ben.boeckel@kitware.com>
2010-12-21 08:25:33 -05:00
Brad King d8e0bfa786 KWSys: Teach SystemInformation about WinXP Pro and Win7
Modify a few lines in the function QueryOSInformation.

Change-Id: Ief8327144fdf5588354d4ce8240eb0206722e77e
Author: Marius Staring <m.staring@lumc.nl>
2010-11-09 10:50:03 -05:00
Dave Partyka 9345833272 BUG: Commit a fix from Rusty to address incorrectly reported memory queries. 2010-03-26 14:18:24 -04:00
David Cole 146cb98cb0 Add fallback for detecting CPU speed from Windows registry on builds where USE_ASM_INSTRUCTIONS gets defined to 0. (Win64 builds.) Clean up methods to return false when not implemented or when they fail to detect the things they're supposed to detect. This file still needs a lot more work to have a fully working implementation on Win64 builds. Committing it now because it's slightly better than it was, and there is a need for the CPU speed detection code in projects that depend on kwsys. Will file a bug shortly to request that the missing implementations get filled in... 2009-12-11 13:08:29 -05:00
David Cole ba21622048 Fix bogus calls to GetMemoryStatus and GetMemoryStatusEx: need to set the dwLength member of the struct prior to calling. Otherwise it's just a garbage value from the stack. Also, pay attention to return value of GetMemoryStatusEx: if it indicates failure then just return 0 without using any of the other data the call returns. 2009-11-18 11:22:38 -05:00
Luis Ibanez 69fdf711fe COMP: Fixing return type of the Get methods associated with variables that
were changed from "unsigned long" to "size_t" to solve warnings about
      64 bits to 32 bits truncations.
2009-11-16 12:43:44 -05:00
Luis Ibanez 7f601830a2 COMP: Fixing type declarations and type conversions that could potentially
truncate 64 bits types into 32 bits types.
2009-11-15 15:57:06 -05:00
Zach Mullen 8fe2738096 Added OS Platform (cpu architecture) detection support to windows systems 2009-10-09 11:10:06 -04:00
Zach Mullen 2af045dfc5 Trimmed off the newline from sw_vers output on mac, it could cause xml parsing errors if left in 2009-10-08 10:56:55 -04:00
Zach Mullen 80533948b2 Fix bus error on mac. Was a result of not having null termination of arg list to sw_vers calls. 2009-10-06 14:55:48 -04:00
Zach Mullen 444e581860 Added better OS information for Mac OS X 2009-10-06 11:46:16 -04:00
Brad King de955e4b6d Convert KWSys to OSI-approved BSD License
This converts the KWSys license to a pure 3-clause OSI-approved BSD
License.  We drop the previous license clause requiring modified
versions to be plainly marked.  We also update the KWSys copyright to
cover the full development time range.
2009-09-28 11:37:35 -04:00
Bill Hoffman 5634ca02f4 ENH: make this work for older versions of OSX 2009-05-20 09:50:20 -04:00
Bill Hoffman bb7230cc96 ENH: revert back because it does not build on older macs for now 2009-05-19 21:50:19 -04:00
Bill Hoffman 46a20bbd4c ENH: remove warning 2009-05-19 16:56:47 -04:00
Bill Hoffman 4220e7c62c ENH: make this build on other machines besides the mac 2009-05-19 16:46:24 -04:00
Bill Hoffman d3d33a3549 ENH: fix system info for mac 2009-05-19 16:35:13 -04:00
Brad King ae284cc5c8 BUG: Fix parsing of linux 2.6 /proc/meminfo format
Previously KWSys SystemInformation parsed this file assuming a strict
order and set of fields, but the order is not reliable.  This
generalizes the implementation to support any order and extra fields.
2009-04-06 14:55:54 -04:00
Francois Bertel ad4a2fd697 COMP:Fixed warnings with gcc 4.3.2. 2009-03-19 22:48:05 -04:00
Bill Hoffman 3d0e241498 BUG: #8496 add support for system info on haiku 2009-02-12 10:08:15 -05:00
Francois Bertel ef36d72c89 COMP:Fixed warnings. 2008-12-15 17:19:26 -05:00
Bill Hoffman 7c2445212e BUG: fix cpu info string 2008-12-04 10:51:11 -05:00
Sebastien Barre 4ed9faa830 ENH: fix for VS6 and Cygwin 2008-10-17 11:29:30 -04:00
Sebastien Barre 8e5886e652 ENH: fix for Vista 2008-10-16 19:30:49 -04:00
Bill Hoffman 2f082668bd ENH: fix crash on dash17 linux where the parsing of the proc file must not have worked right 2008-06-01 23:40:30 -04:00
Bill Hoffman 735b77798d ENH: fix crash on cygwin 2008-06-01 16:11:38 -04:00
Francois Bertel d0237abfd4 BUG:cpuinfo format are different between Linux and Cygwin. Cygwin does not have physical id tag or cpu cores tag. 2008-06-01 14:40:11 -04:00
Bill Hoffman fc5bc3380e ENH: avoid divide by zero, temporary fix until cygwin cpu file is read better, bad cpu info is better than a crash 2008-06-01 11:23:22 -04:00
Francois Bertel f9ce6fcb5a BUG:Fixed NumberOfLogicalCPU, NumberOfPhysicalCPU and LogicalProcessorsPerPhysical under Linux. Some part was just wrong. Some other part missed to take the multicore value into account. 2008-05-31 11:23:15 -04:00
Bill Lorensen 68dfcefbcb COMP: sprintf warnings. DWORD should use %ld rather than %d. Also, const char *p, a shadowed variable warning. 2008-05-10 22:48:53 -04:00
Bill Hoffman bf8ed70534 BUG: really fix build on vs6 2008-05-02 17:36:08 -04:00
Bill Hoffman 47fa89b6e9 BUG: fix build on vs6 2008-05-02 17:22:46 -04:00
Bill Hoffman 9c63132c3c ENH: use GlobalMemoryStatusEx as it is able to report more than 2gigs 2008-05-02 11:44:26 -04:00
Brad King ab0c2757d5 COMP: Fix warnings in KWSys SystemInformation on Borland compiler.
- Remove two unused variables.
  - Replace dynamically allocated array with static.
2008-05-02 09:14:37 -04:00
Bill Hoffman d47734bd98 ENH: remove odd chars from file 2008-04-24 15:47:36 -04:00
Brad King 6b8bb7d7fa COMP: Fix warning in SystemInformation.cxx about possibly incorrect assignment in if condition. 2008-02-03 08:20:11 -05:00
Brad King 8280232d0d COMP: Fix unreachable code warning. Remove runtime test of constant information. 2008-02-03 08:14:38 -05:00
Bill Hoffman e3b0d3927a ENH: fix infinite loop from size_t change 2008-02-02 16:18:35 -05:00
Bill Hoffman 15741325e0 ENH: fix warnings 2008-02-01 12:35:50 -05:00
Bill Hoffman 2564097e8c ENH: fix more warnings 2008-02-01 11:40:55 -05:00
Bill Hoffman 5343910cba ENH: fix more warnings 2008-02-01 11:36:06 -05:00
Bill Hoffman 889d900ef2 ENH: fix more warnings 2008-02-01 11:34:42 -05:00
Bill Hoffman f6826df4f3 ENH: fix more warnings 2008-02-01 11:33:14 -05:00
Bill Hoffman 9b55f81522 ENH: fix some warnings and 64 bit build windows 2008-02-01 11:30:08 -05:00
Bill Hoffman 32409bb8e3 ENH: fix win64 build and a warning 2008-02-01 11:09:39 -05:00
Bill Hoffman cc7c89ca51 ENH: try to fix hp and vs 6, again... 2008-01-31 21:33:32 -05:00
Bill Hoffman 294dca62ee ENH: fixes for borland 2008-01-31 16:37:52 -05:00
Bill Hoffman 52e75800b4 ENH: fix for qnx, I hope, and fix indent stuff 2008-01-31 15:34:09 -05:00
Bill Hoffman 99ebc1e728 ENH: fix build errors with asm stuff on mingw and hopefully win64 2008-01-31 15:10:19 -05:00
Bill Hoffman 414b89b903 ENH: fix build for mingw 2008-01-31 14:50:08 -05:00