050af165bb
Fix integer conversions in cpack
...
These were revealed by GCC's -Wconversion option.
2010-06-30 09:57:07 -04:00
415900ba77
Eliminate -Wconversion warnings.
...
Change types of local variables, or casting, or re-arrange
expressions to get rid of "conversion may alter value" warnings
as seen on recent dashboard submissions from londinium.kitware.
2010-06-27 11:22:05 -04:00
fdb5f78705
CPack: Try harder to remove temporary dir ( #10793 )
...
Windows filesystems sometimes lock files temporarily. Try removing the
CPack temp install folder multiple times before giving up.
2010-06-04 14:32:08 -04:00
10a4abddfd
Add missing archive_read_finish calls to fix some of the presently reported valgrind memory leaks.
2009-12-28 13:15:19 -05:00
22fb266d06
use different tar format to handle longer file names
2009-11-14 08:48:32 -05:00
70dbbcc542
add better error checking and run from correct directory.
2009-11-09 09:58:03 -05:00
4fd75f959a
add better error checking and support for symlinks to cpack's use of libarchive
2009-11-08 20:54:13 -05:00
b0d43475c6
Fix warning
2009-11-03 17:21:25 -05:00
5f41fe03ca
Fix warnings for unused variables
2009-11-03 16:50:49 -05:00
78b2d5097c
Fix cygwin package stuff to work with libarchive
2009-11-03 09:40:57 -05:00
d4b8945301
Fix for hpux...
2009-11-02 09:20:53 -05:00
fb51d98562
Switch to using libarchive from libtar for cpack and cmake -E tar
...
This allows for a built in bzip and zip capability, so external tools
will not be needed for these packagers. The cmake -E tar xf should be
able to handle all compression types now as well.
2009-10-30 13:10:56 -04:00
43d07f6620
Fix more mismatched new[] / delete[] (eliminate invalid auto_ptr use) to correct valgrind reported memory issues.
2009-10-30 10:31:54 -04:00
e0bbaa889a
Correct one of the valgrind errors from the CPackTestAllGenerators test. Do not use auto_ptr on a new [] allocation because auto_ptr does not use delete [].
2009-10-26 13:49:20 -04:00
a9fa71a47c
Try to avoid cronic random failures on some Macs.
2009-10-04 09:54:55 -04:00
78f68ef1b7
Try to avoid cronic random failures on some Macs.
2009-10-04 09:32:48 -04:00
eb91859d6f
remove unused variables, reported by icpc
...
Alex
2009-10-03 08:35:57 -04:00
44bcba7461
Fix warnings in CMake source code. Suppress rampant warnings emanating from Qt files.
2009-10-01 16:47:08 -04:00
f40406ed6b
Fix default install prefix on Haiku
...
Since Haiku does not have /usr (and therefore /usr/local), this commit
changes the default install prefix to the equivalent directory of
/boot/common.
See issue #9607 .
2009-09-30 08:31:53 -04:00
a091e99cb9
Fix issue #8818 - escape quotes in the license file when using the DragNDrop cpack generator. Thanks to Clinton Stimpson for the patch.
2009-09-28 17:14:53 -04:00
96afb12087
Convert CMake to OSI-approved BSD License
...
This converts the CMake license to a pure 3-clause OSI-approved BSD
License. We drop the previous license clause requiring modified
versions to be plainly marked. We also update the CMake copyright to
cover the full development time range.
2009-09-28 11:43:28 -04:00
b41a548d86
Add parentheses around '&&' between '||' for gcc
...
The GNU compiler warns about possible operator precedence mistakes and
asks for explicit parentheses (-Wparentheses). We add the parentheses
to silence the warning. This also fixes one real logic error in the
find_package() implementation by correcting expression evaluation order.
2009-09-11 08:18:15 -04:00
e9d7ebb3ec
BUG: Do not double-initialize local generators
...
All global generator CreateLocalGenerator methods automatically
initialize the local generator instances with SetGlobalGenerator. In
several places we were calling SetGlobalGenerator again after receiving
the return value from CreateLocalGenerator. The double-initializations
leaked the resources allocated by the first call to SetGlobalGenerator.
This fix removes the unnecessary calls.
2009-07-28 10:47:02 -04:00
42c033ccd6
BUG: Fix issue #8759 - add support for setting dmg volume name and compression type by CPack variables. Also add custom .DS_Store and background image support. Thanks to Mike Arthur for the patches.
2009-04-03 13:12:53 -04:00
60a46ca76e
STYLE: Fix line length violation.
2009-02-24 09:34:03 -05:00
c148714b82
ENH: Add license file presentation to the Drag-N-Drop dmg file CPack generator. Fixes issue #8442 . Thanks to Clinton Stimpson for the patch.
2009-02-23 13:25:18 -05:00
c6051d7ad0
STYLE: Fix style line-too-long violations.
2009-02-20 10:14:40 -05:00
1bf669207b
BUG: A little bit more refactoring from BundleGenerator to DragNDropGenerator. See issue #8556 . Thanks for Clinton Stimpson for the patch.
2009-02-19 10:39:08 -05:00
dc13914cd6
ENH: Create cmXMLSafe to help escapes in XML
...
This class provides easy syntax to efficiently insert blocks of data
into XML documents with proper escapes. It replaces the old
cmCTest::MakeXMLSafe and cmSystemTools::MakeXMLSafe methods which
allocated extra memory instead of directly streaming the data.
2009-02-05 16:31:37 -05:00
2914b740c2
BUG: Forgot to change parent class in cmCPackTypeMacro when I added cmCPackDragNDropGenerator. Fix it now that it really matters. (The BundleGenerator test started failing after the last commit. This fixes it.)
2009-01-22 14:23:44 -05:00
6bf31875ce
BUG: Fix issue #8383 . Avoid crashing when using the Bundle CPack generator and CPACK_BUNDLE_NAME is not set. Instead, fail gracefully giving an informative error message and non-zero exit code.
2009-01-22 13:56:13 -05:00
3a4f76949a
BUG: Fix issue #8402 . Add a drag and drop bundle generator to the Mac build of CPack. Add a test of it in the CPackComponents test. Thanks to Clinton Stimpson for the patch.
2009-01-22 12:12:44 -05:00
36c228814b
BUG: Fix issue #7523 : Analyze output of 'hdiutil attach' to get the name of the volume that was mounted. Eliminates the need to use the -mountpoint arg of hdiutil which has a silly 90 character limit on the name of the mount point. Also add a custom volume icon to the BundleGeneratorTest to cover this code.
2009-01-21 13:39:22 -05:00
c647ed54d9
BUG: Fix issue #7833 : Add file extension handling to CPack generated installers for OSXX11 applications. Also modify the X11 test to build such an installer on Mac builds that test CPack and have X11 available. Thanks to Wes Turner for the patch.
2009-01-21 11:54:30 -05:00
03c940aeb3
BUG: Fix for issue #7470 . Allow spaces in the path names of installed files with the NSIS CPack generator and component-based installs. Add an installed file to the CPackComponents test: it failed before the fix; now it passes.
2009-01-20 14:29:41 -05:00
81515ba8a5
ENH: allow startup command to be optional
2008-12-04 09:09:55 -05:00
cc51ddd34b
BUG: Use the DESTDIR prefix when creating the directory in CPack when CPACK_SET_DESTDIR is ON. Thanks to Petri Hodju for reporting this regression to the CMake mailing list: http://www.cmake.org/pipermail/cmake/2008-October/024563.html .
2008-10-15 09:35:27 -04:00
c3976b0283
BUG: Fix issue #7800 . Enable CPack to find the NSIS installer on Windows 2000.
2008-10-10 17:08:00 -04:00
71fee8522e
STYLE: fix line length issues
2008-10-02 09:18:47 -04:00
ecf312ccc8
STYLE: fix line length stuff for KWStyle
2008-10-01 09:04:27 -04:00
d31c890220
ENH: missed one
2008-09-24 10:01:32 -04:00
302aadadb3
STYLE: fix compiler warning
2008-09-24 09:57:52 -04:00
7fd080d695
STYLE: fix warning and rename method
2008-09-23 10:15:13 -04:00
52e6733fbc
BUG: fix 7669, cpack did not work with symlinks
2008-09-22 18:12:54 -04:00
7e5222165d
ENH: add installed size to deb package
2008-09-11 10:48:49 -04:00
b2f041f6a8
BUG: Fix issue #7414 - do not crash when given components with circular dependencies. Thanks to Doug Gregor for the patch.
2008-07-30 13:28:17 -04:00
b3752abc8d
ENH: Improvements to the bundle cpack generator from second patch attached to feature request #7170 . Thanks to Tim Shead.
2008-07-18 16:12:36 -04:00
d7b9041516
COMP: Fix HP continuous. Pull stl headers into CMake header files using cmStandardIncludes.h
2008-07-09 16:30:53 -04:00
71f61636b6
ENH: One more patch from Doug Gregor including PackageMaker functionality for componentized-for-the-end-user and download-some-bit-on-demand installers.
2008-07-09 13:38:56 -04:00
83ec8c3593
ENH: Further refinement of the CPack components functionality from Doug Gregor.
...
Details:
==========
- New cpack_add_component, cpack_add_component_group, and
cpack_add_install_type "commands" defined as macros in the CPack
module.
- Documentation for all of the variables and commands in the CPack module.
- Added get_cmake_property(... COMPONENTS) to CMake to ask for the
names of all components. Used in the CPack module to automatically
build component-based installers. (Set CPACK_MONOLITHIC_INSTALL to
turn off component-based installation).
- A group can declare its PARENT_GROUP, to build an arbitrary
hierarchy of groups.
- New CPack command cpack_configure_downloads, which creates an
installer that downloads only the selected components on-the-fly.
Those components marked DOWNLOADED will be separate packages
downloaded on-the-fly (or, all packages can be marked as such with the
ALL option to cpack_configure_downloads). Individual components are
compressed with ZIP at installer-creation time and
downloaded/uncompressed by the installer as needed. This feature is
only available on Windows with NSIS at the moment.
- NSIS installers can install themselves and enable the "Change"
button in Add/Remove programs, allowing users to go back and install
or remove components. This can be disabled through
cpack_configure_downloads, because it's only really useful is most of
the application's functionality is in downloaded components.
- Bug fix: automatically install everything whose COMPONENT was not
specified (it's a hidden, required group)
- Bug fix: fixed removal of components when re-running the NSIS
installer and unchecking components
- Bug fix: NSIS installers now only install/remove the minimal
number of files when re-run to update the installation (or by clicking
"Change" in Add/Remove programs)
2008-07-08 11:52:25 -04:00
01a93bbb3e
COMP: Eliminate unreferenced variable warning
2008-06-19 06:17:01 -04:00
974feca643
COMP: Eliminate compiler warning on 64-bit build.
2008-06-18 16:00:05 -04:00
0fe9afdf5e
BUG: Always look for the NSIS reg value in the 32-bit hive even in 64-bit builds of CPack.
2008-06-18 14:25:57 -04:00
79e255a7d3
ENH: Apply patch for feature request #7170 . Thanks to Tim Shead for contributing...
2008-06-18 09:53:29 -04:00
e8825d320b
BUG: Workaround PackageMaker 3.0 issue for new CPack components feature. Thanks again to Doug Gregor for the patch.
2008-06-18 07:08:33 -04:00
5cd8c61db3
COMP: Use cmOStringStream instead of std::ostringstream for the HP compiler.
2008-06-17 14:07:15 -04:00
9a98928bd9
COMP: Fix errors and warnings from continuous dashboards running different compilers...
2008-06-17 12:44:18 -04:00
80714fb42f
COMP: Include full class definitions of classes used in std::map data members.
2008-06-17 12:09:42 -04:00
1105a86c52
ENH: Add patch for feature request #6847 - CPack components for NSIS and PackageMaker installers. Thanks to Doug Gregor for all the hard work involved with implementing this patch! Also added new test CPackComponents that is conditionally executed only when NSIS or PackageMaker installer builders are available.
2008-06-17 11:39:26 -04:00
e7948f89f9
COMP: auto_ptr will not compile without including memory on some platforms
2008-04-18 10:55:04 -04:00
968706b29e
BUG: Fix mem leak. Thanks, Mathieu.
2008-04-17 12:06:20 -04:00
2efad09d92
ENH: add CPACK_DEBIAN_PACKAGE_CONTROL_EXTRA variable
2008-04-01 17:51:10 -04:00
12ba1e9b20
BUG: fix packaging of files installed to absolute paths, works only when
...
used with SET(CPACK_SET_DESTDIR "ON")
Alex
2008-03-28 20:23:01 -04:00
042f4c334d
ENH: fix crash in cpack when CPACK_CYGWIN_PATCH_NUMBER not specified
2008-03-12 21:54:27 -04:00
497779d4b3
ENH: fix crash in cygwin package stuff
2008-03-07 11:06:44 -05:00
ee2a13b11f
ENH: install working with symlink qt tool
2008-02-19 14:26:20 -05:00
ef537ffec7
ENH: have cpack work with DESTDIR install and ingest qt framework libs into cmake-gui
2008-02-18 10:26:28 -05:00
337c1f0b72
ENH: fix DESTDIR install
2008-02-16 13:02:57 -05:00
6ea4eea183
BUG: fix for bug 6294, correct url for nsis
2008-02-15 10:40:55 -05:00
f5d86035f2
COMP: Add include of <limits.h> to get USHRT_MAX constant.
2008-01-24 07:31:59 -05:00
4c108d2a24
ENH: try to fix dashboard
2007-12-17 15:27:30 -05:00
ad75cb7195
BUG: fix for 6086 uninstall icon not set right
2007-12-14 14:58:27 -05:00
9f61e2a235
ENH: Centralized and globalized computation of CMake program locations. This eliminates startup paths that failed to produce this information.
2007-12-13 17:56:50 -05:00
87c22309b8
ENH: change CPACK_CREATE_DESKTOP_LINKS to something that can handle spaces in the name of the exectuable
2007-11-07 13:11:58 -05:00
33478faeb6
ENH: changne ProcessGenertor to DoPackage
2007-11-06 08:28:26 -05:00
cfd308ce43
STYLE: fix line length issue
2007-11-06 08:27:43 -05:00
743cec67d5
ENH: change name
2007-11-05 16:55:45 -05:00
62decc533b
ENH: change name of class
2007-11-05 16:33:19 -05:00
f410f8578e
COMP: Fix warnings on 64-bit Mac OS X build. Patch from issue #3697 .
2007-11-05 14:34:36 -05:00
e65c40f94a
ENH: add CPACK_PROJECT_CONFIG_FILE option to CPack
2007-10-31 12:55:04 -04:00
771997c556
ENH: fix line length
2007-10-31 09:03:40 -04:00
5beb1da7f7
ENH: Add CPACK_SET_DESTDIR handling to enable packaging of installed files in absolute locations. With this setting on, cpack will set the DESTDIR env var when building the package so that files end up in their intended locations. Default behavior is not to set DESTDIR for backwards compatibility. Helps address issue #4993 and issue #5257 . Also, remove unused CPACK_USE_DESTDIR variable. ENH: Add variable CPACK_PACKAGING_INSTALL_PREFIX to allow overriding the CPack GetPackagingInstallPrefix from a project's CMakeLists file if necessary. Could be used to remove the annoying /usr prefix still used by default in the Mac PackageMaker generator.
2007-10-31 08:50:17 -04:00
eb14543939
ENH: cpack changes, remove the escape variable stuff as it is not needed if you provide a config file for cpack
2007-10-30 23:02:43 -04:00
02f79c7242
ENH: add ability to set installer icons, links to web pages, nsis code in the icon section of the template, and ability to escape variables correctly
2007-10-29 08:11:44 -04:00
2d1bcf806f
BUG: rename DEBIAN_PACKAGE_* variables to CPACK_DEBIAN_PACKAGE_* variables
...
to make them actually work
Alex
2007-10-25 13:26:54 -04:00
6cdf032505
ENH: change to make the documentation class more generic, about halfway there, also provides secitons for Variables now
2007-10-22 12:49:09 -04:00
4168c0797b
ENH: fix line length error
2007-10-19 12:03:16 -04:00
3e03bca2cd
ENH: add ability to create links on the start menu
2007-10-18 09:40:10 -04:00
35e13b11f3
BUG: revert doc changes since VS7 cannot compile them, will implement them in a different manner
2007-10-09 14:35:25 -04:00
18ce24c748
ENH: make documentation entries actually store their data
2007-10-09 09:55:42 -04:00
887699184a
COMP: remove warnings
2007-09-27 14:44:11 -04:00
d5b135e6b5
STYLE: use %-10lld instead of %-10qd for printing a 64bit int, maybe this
...
silences the warning of the HP compiler
Alex
2007-09-21 13:37:30 -04:00
0eba9b638f
ENH: allow for desktop link to be created and fix chop of last char in PATH on uninstall
2007-09-18 15:16:21 -04:00
20455c699b
BUG: Another space-in-path fix.
2007-08-31 09:14:43 -04:00
e47fbcb9a8
BUG: work if there are spaces in the path to cmake
...
Alex
2007-08-29 16:32:20 -04:00
feda0041c3
STYLE: InitializeInternal() is unused
...
Alex
2007-08-17 09:33:29 -04:00
45da4d2f80
ENH: patch from Eric Noulard for an RPM package generator
...
It seems rpmbuild can't handle paths with spaces, it complains that
Buildroot takes only one tag (or something like this), quoting and escaping
don't seem to help.
Alex
2007-08-17 09:13:15 -04:00
911613edf0
COMP: fix warning about comparison signed - unsigned
...
Alex
2007-08-15 08:47:28 -04:00
1dde4ab36c
COMP: fix build on HPUX, snprintf apparently doesn't work there
...
Alex
2007-08-15 08:28:08 -04:00
eff7981b57
STYLE: another patch from Mathieu with some comments
...
Alex
2007-08-14 10:25:23 -04:00
dfbd4ce0f2
ENH: deb generator: don't use the system provided ar, but do it yourself
...
using the code from OpenBSD ar
COMP: don't build all package generators on all platforms
Alex
2007-08-14 08:40:40 -04:00
406349a1d1
COMP: silence warnings
...
Alex
2007-08-08 15:44:02 -04:00
c5d79a298d
BUG: register the rpm generator for RPM
...
Alex
2007-08-08 14:44:54 -04:00
4ba24ce474
ENH: patch from Mathieu: more entries in the debian control file
...
Alex
2007-08-08 14:18:13 -04:00
7432ef206e
ENH: add empty RPM package generator, Eric Noulard wants to work on it
...
Alex
2007-08-08 11:33:42 -04:00
f23169b01a
ENH: another fix for the deb generator by Mathieu
...
Alex
2007-08-06 13:31:37 -04:00
4040f5f1bf
BUG: patch from Mathieu: the md5sums were not correct
...
Alex
2007-08-06 09:03:10 -04:00
68674bd0d7
ENH: better error messages from the debian package generator
...
-don't display the cpack help if a generator failed with some problem
-check for cmSystemTools::GetErrorOccuredFlag()
Alex
2007-08-03 15:26:30 -04:00
c693a23a7d
ENH: use gnu tar for cygwin
2007-07-30 22:51:21 -04:00
42f9a6eb08
STYLE: fix line length
...
Alex
2007-07-27 13:12:36 -04:00
2745742e09
STYLE: fix some kwstyle errors
2007-07-27 10:55:24 -04:00
d6a0c330bc
ENH: deb generator can now generate deb packages
...
-remove the unscriptable commands also from the cpack cmake
-use CPACK_PACKAGE_CONTACT in CMakeCPack.cmake, it's used in the nsis and
the deb generator
-make set_properties() scriptable
-use a non-const char array for adding the python modules
Alex
2007-07-27 08:59:59 -04:00
0ea4c7b784
STYLE: fix line lengths
...
Alex
2007-07-26 08:40:51 -04:00
9c2d6f98d7
ENH: apply patch from Mathieu which creates a deb file (not finishsed yet)
...
Alex
2007-07-25 13:08:17 -04:00
8796bfcbaf
COMP: silence warnings
...
Alex
2007-07-25 11:41:25 -04:00
a39aff52a0
ENH: add an empty debian package generator, Mathieu volunteered to fill it
...
:-)
Alex
2007-07-25 10:57:33 -04:00
919265516e
ENH: add ReadListFile() to cmCPackGenericGenerator, so cmMakefile can be
...
private again
-convert the ZIP generator to use a cmake script instead of hardcoding
everything (CPackZIP.cmake)
Alex
2007-07-24 12:52:39 -04:00
8a6e2bb81d
ENH: determine the current system also in cpack, so the search paths are
...
loaded
Additionally the makefile in cmCPackGenericGenerator is now protected
instead of private, so with these two changes the cpack generators should
now be able to find their tools and how to call these tools from cmake
scripts, instead of hardcoding the search order and command line (as done
e.g. in cmCPackZIPGenerator.cxx)
Alex
2007-07-24 10:00:26 -04:00
8c77fe55dc
STYLE: fix some typos, nicer debug output
...
Alex
2007-07-19 11:13:01 -04:00
ef81ac50e5
ENH: NSIS exists also for Linux, not only Windows, so enable it there too
...
patch by Michal Čihař <michal (AT) cihar.com>
Alex
2007-06-18 09:00:33 -04:00
2f6f3316e4
STYLE: fix typo
...
Alex
2007-06-14 13:57:00 -04:00
f80d98bc09
ENH: support 7zip for creating zip files (not 7z files)
...
Alex
2007-06-14 12:03:53 -04:00
9670a8c485
ENH: 2nd try to move stripping out of cpack and to install time, now if
...
CPACK_STRIP_FILES is true (or contains a list of files), everything will be
stripped, if it's empty or false they won't be stripped
Alex
2007-05-18 14:41:09 -04:00
d64dc9b5bb
COMP: force a recompile on VS71
...
Alex
2007-05-18 11:45:18 -04:00
8f870ddeca
BUG: fix coverity error, null check after usage fix
2007-03-20 12:44:36 -04:00
b41d4a1b54
STYLE: fix someones line length
2007-02-22 09:44:27 -05:00
f7cd9f76ce
STYLE: fix line length issues
2007-02-17 08:46:25 -05:00
f2c0dbd164
ENH: More work on the packaging. Add Applicaitons, add icons, etc
2007-02-13 14:13:51 -05:00
266971e302
STYLE: fix warnings
2007-02-02 16:52:20 -05:00
4925e64b97
ENH: add support for cygwin source and binary packaging
2007-02-02 14:40:26 -05:00
39eba4ce11
ENH: commit cygwin source generator files, not used yet
2007-01-31 16:50:24 -05:00
4240fc1bcb
COMP: Use new API
2007-01-31 13:53:30 -05:00
8388640c03
STYLE: Fix kwstyle
2007-01-15 12:31:29 -05:00
cd5535ee9c
STYLE: Fix kwstyle issues
2007-01-11 10:49:18 -05:00
c3148813f4
ENH: fix warning and code style
2007-01-10 19:59:53 -05:00
de5540f7e5
ENH: First pass at CPack generator for OSX X11 applications. This are applications that require X11 to work. This is not really installed but a bundle packager
2007-01-10 15:30:26 -05:00
240deb027b
STYLE: fix a long line
2006-11-17 11:14:04 -05:00
2e37a00610
ENH: Expand comment
2006-11-13 22:08:42 -05:00
7aef92391b
ENH: make sure null const char* is not put into ossttringstream to avoid seg faults
2006-10-30 11:22:48 -05:00
f91b3c1daa
ENH: Add options to build with system utility libraries. Organize inclusion of third party libraries into a single header per library. This addresses bug#3653.
2006-10-19 15:00:10 -04:00
4d6435f5f3
STYLE: Fixed line-too-long.
2006-10-17 09:34:07 -04:00
2071291956
STYLE: Fix kwstyle
2006-10-15 07:54:52 -04:00
b548e2db1f
ENH: Add NSIS compression
2006-10-12 14:59:43 -04:00
e31dc3abe5
ENH: Several CPack fixes. First, allow user to set CMAKE_MODULE_PATH for CPack; make SetOptionIfNotSet more robust to handle empty options; do test TGZ, STGZ, and TZ, Add handling (and test) of Install Script; set environment variable CMAKE_INSTALL_PREFIX
2006-10-12 13:05:50 -04:00
c9fd17b884
BUG: Attempt to fix winzip problems
2006-09-23 14:41:08 -04:00
0952a96485
ENH: Handle zip (command line was too long)
2006-09-21 15:09:34 -04:00
2b602ea738
COMP: Need to use cmsys_stl when in CMake code, not kwsys_stl.
2006-08-27 13:15:39 -04:00
377e4c132f
COMP: Remove warnings
2006-08-22 09:20:44 -04:00
07fa9ac09c
ENH: Implement TarCompress generator using compress library
2006-08-21 12:37:40 -04:00
b24533f27c
ENH: fix line lengths
2006-07-31 10:28:30 -04:00
Brad King
David Cole
Bill Hoffman
Alexander Neundorf
Ken Martin
Andy Cedilnik