kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
23,903 Commits 1 Branch 14 Tags 53 MiB
Commit Graph

11 Commits

Author SHA1 Message Date
Stephen Kelly 272a20f8e5 cmTarget: Don't update IMPORTED target compilation properties 
The include_directories() and add_compile_options() commands
should not append to the corresponding target property for IMPORTED
targets.  This is already the case for add_definitions().
 2014-01-04 11:28:57 +01:00
Stephen Kelly c0b8682200 Allow target commands to be invoked with no items (#14325). 
Code such as

 target_include_directories(foo PRIVATE ${items})

should not work or break based on whether items is defined or not.
 2013-07-31 16:06:34 +02:00
Stephen Kelly cbf07569ed Revert "Add the TARGET_DEFINED generator expression" 
This reverts commit 2bee6f5ba5.

This expression is not used, and has a semantic which is not completely
optimal (namely considering utility targets to be targets, though
usually we are interested in linkable targets).

Remove it so that we have more freedom to define better expressions in
the future.

Conflicts:
        Source/cmGeneratorExpressionEvaluator.cxx
        Tests/CMakeCommands/target_compile_definitions/CMakeLists.txt
        Tests/CMakeCommands/target_compile_definitions/consumer.cpp
 2013-02-25 15:35:11 +01:00
Stephen Kelly 3df36b5954 Revert "Add the $<LINKED:...> generator expression." 
This reverts commit 0b92602b81.

Conflicts:
	Source/cmGeneratorExpressionEvaluator.cxx
	Tests/CMakeCommands/target_compile_definitions/CMakeLists.txt
	Tests/CMakeCommands/target_include_directories/CMakeLists.txt
 2013-02-13 15:12:31 +01:00
Stephen Kelly 5c9f5e313f Don't use LINKED where not needed. 2013-02-12 10:39:35 +01:00
Stephen Kelly 0b92602b81 Add the $<LINKED:...> generator expression. 
This is both a short form of using a TARGET_DEFINED expression
together with a TARGET_PROPERTY definition, and a way to strip
non-target content from interface properties when exporting.
 2013-01-31 17:34:20 +01:00
Stephen Kelly 7bf490e9bb Make subclasses responsible for joining content. 
This way we can add handling of relative/absolute paths and of
-D in compile definitions.
 2013-01-29 19:34:04 +01:00
Stephen Kelly f6b16d4b06 Don't allow targets args in the new target commands. 2013-01-29 18:44:54 +01:00
Stephen Kelly b98d14d400 Disallow porcelain to populate includes and defines of IMPORTED targets. 
With similar reasoning to the parent commit, as downstreams, we can't
determine what $<CONFIG> generator expressions would be appropriate.

Upstream would have populated the INTERFACE_INCLUDE_DIRECTORIES with
config-specific generator expressions, possibly appropriate for
their DEBUG_CONFIGURATIONS. In theory, if we would add include
directories for a DEBUG intent, we would have to match the upstream
configurations for that.

Rather than attempting to discover the appropriate configurations
at this time, simplify the feature instead. The use of IMPORTED targets
with these commands could still be added in the future if targets
would export their DEBUG_CONFIGURATIONS somehow.
 2013-01-21 12:32:46 +01:00
Stephen Kelly 2bee6f5ba5 Add the TARGET_DEFINED generator expression 
This tests whether the parameter is a usable target.
 2013-01-14 00:08:47 +01:00
Stephen Kelly fc61a7a746 Add the target_compile_definitions command. 
This is a convenience API to populate the corresponding properties.
 2013-01-10 09:46:58 -05:00