From ffedf3527d7e714b6885b822ee85889016418ebb Mon Sep 17 00:00:00 2001
From: Rolf Eike Beer <eike@sf-mail.de>
Date: Wed, 20 Apr 2016 23:14:52 +0200
Subject: [PATCH] make cmGlobalXCodeGenerator::BuildObjectListOrString::Add()
 take a string&

All callers already have these objects, and it is only passed to other methods
taking such, so avoid all conversions in between.
---
 Source/cmGlobalXCodeGenerator.cxx | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Source/cmGlobalXCodeGenerator.cxx b/Source/cmGlobalXCodeGenerator.cxx
index 0050bf4d1..5e6834547 100644
--- a/Source/cmGlobalXCodeGenerator.cxx
+++ b/Source/cmGlobalXCodeGenerator.cxx
@@ -84,7 +84,7 @@ public:
 
   bool IsEmpty() const { return this->Empty; }
 
-  void Add(const char *newString)
+  void Add(const std::string& newString)
     {
     this->Empty = false;
 
@@ -2285,14 +2285,14 @@ void cmGlobalXCodeGenerator::CreateBuildSettings(cmGeneratorTarget* gtgt,
       frameworkDir = cmSystemTools::CollapseFullPath(frameworkDir.c_str());
       if(emitted.insert(frameworkDir).second)
         {
-        fdirs.Add(this->XCodeEscapePath(frameworkDir.c_str()).c_str());
+        fdirs.Add(this->XCodeEscapePath(frameworkDir.c_str()));
         }
       }
     else
       {
       std::string incpath =
         this->XCodeEscapePath(i->c_str());
-      dirs.Add(incpath.c_str());
+      dirs.Add(incpath);
       }
     }
   // Add framework search paths needed for linking.
@@ -2304,7 +2304,7 @@ void cmGlobalXCodeGenerator::CreateBuildSettings(cmGeneratorTarget* gtgt,
       {
       if(emitted.insert(*fdi).second)
         {
-        fdirs.Add(this->XCodeEscapePath(fdi->c_str()).c_str());
+        fdirs.Add(this->XCodeEscapePath(fdi->c_str()));
         }
       }
     }
@@ -4025,7 +4025,7 @@ cmGlobalXCodeGenerator::AppendDefines(BuildObjectListOrString& defs,
     // Append the flag with needed escapes.
     std::string tmp;
     this->AppendFlag(tmp, def);
-    defs.Add(tmp.c_str());
+    defs.Add(tmp);
     }
 }