From ff710539ab31ba4b6f3b376621dd9fbd56e1b558 Mon Sep 17 00:00:00 2001 From: Stephen Kelly Date: Tue, 1 Apr 2014 23:53:05 +0200 Subject: [PATCH] Remove default labels from fully covered switch statements. Allow compilers to warn when new enum values are added, making switches no-longer fully-covered. --- Source/cmCTest.cxx | 2 -- Source/cmLocalGenerator.cxx | 1 - Source/cmMakefile.cxx | 1 - Source/cmNewLineStyle.cxx | 2 -- Source/cmTargetLinkLibrariesCommand.cxx | 1 - 5 files changed, 7 deletions(-) diff --git a/Source/cmCTest.cxx b/Source/cmCTest.cxx index 9f711b73b..d797d3bc2 100644 --- a/Source/cmCTest.cxx +++ b/Source/cmCTest.cxx @@ -217,8 +217,6 @@ int cmCTest::HTTPRequest(std::string url, HTTPMethod method, url += "?" + fields; } break; - default: - break; } ::curl_easy_setopt(curl, CURLOPT_URL, url.c_str()); diff --git a/Source/cmLocalGenerator.cxx b/Source/cmLocalGenerator.cxx index dcf9f97eb..1e65a0210 100644 --- a/Source/cmLocalGenerator.cxx +++ b/Source/cmLocalGenerator.cxx @@ -2283,7 +2283,6 @@ bool cmLocalGenerator::GetShouldUseOldFlags(bool shared, case cmPolicies::REQUIRED_IF_USED: case cmPolicies::REQUIRED_ALWAYS: case cmPolicies::NEW: - default: return false; } } diff --git a/Source/cmMakefile.cxx b/Source/cmMakefile.cxx index b1d6fe28f..132897401 100644 --- a/Source/cmMakefile.cxx +++ b/Source/cmMakefile.cxx @@ -3365,7 +3365,6 @@ std::string cmMakefile::GetModulesFile(const char* filename) const case cmPolicies::REQUIRED_IF_USED: case cmPolicies::REQUIRED_ALWAYS: case cmPolicies::NEW: - default: result = moduleInCMakeRoot; break; } diff --git a/Source/cmNewLineStyle.cxx b/Source/cmNewLineStyle.cxx index a7d74297f..08f0b5b09 100644 --- a/Source/cmNewLineStyle.cxx +++ b/Source/cmNewLineStyle.cxx @@ -76,8 +76,6 @@ const std::string cmNewLineStyle::GetCharacters() const return "\n"; case CRLF: return "\r\n"; - default: - ; } return ""; } diff --git a/Source/cmTargetLinkLibrariesCommand.cxx b/Source/cmTargetLinkLibrariesCommand.cxx index 1c2e62570..56e133817 100644 --- a/Source/cmTargetLinkLibrariesCommand.cxx +++ b/Source/cmTargetLinkLibrariesCommand.cxx @@ -70,7 +70,6 @@ bool cmTargetLinkLibrariesCommand GetRequiredPolicyError(cmPolicies::CMP0016); break; case cmPolicies::NEW: // NEW behavior prints the error. - default: break; } }