From 02a545c534d86652595cd282b10cb9ed9fad6239 Mon Sep 17 00:00:00 2001 From: Stephen Kelly Date: Fri, 29 Nov 2013 01:33:53 +0100 Subject: [PATCH] Don't generate subdir convenience rules for IMPORTED targets. This was missing from commit c34968a9 (Port some of the generator API to cmGeneratorTarget., 2012-10-10). The generator targets stored with the cmMakefile include IMPORTED targets, unlike the accessor for resgular targets. Before this patch, rules would be generated for Qt5::Core for example, which result in broken makefiles. --- Source/cmLocalUnixMakefileGenerator3.cxx | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Source/cmLocalUnixMakefileGenerator3.cxx b/Source/cmLocalUnixMakefileGenerator3.cxx index 9af5c29b4..df5da5da7 100644 --- a/Source/cmLocalUnixMakefileGenerator3.cxx +++ b/Source/cmLocalUnixMakefileGenerator3.cxx @@ -390,6 +390,11 @@ void cmLocalUnixMakefileGenerator3 (t->second->GetType() == cmTarget::INTERFACE_LIBRARY) || (t->second->GetType() == cmTarget::UTILITY)) { + if (t->second->Target->IsImported()) + { + continue; + } + emitted.insert(t->second->GetName()); // for subdirs add a rule to build this specific target by name.