kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Tests: ExternalProject: Remove unnecessary 'svn --version' call 

This test will fail to get a proper version number if running on a (e.g.
German) localized system because the regular expression used to match the
Subversion version output does not match. Instead of duplicating code just
remove the local test altogether and use the version that FindSubversion.cmake
already detects.
This commit is contained in:
Rolf Eike Beer 2011-11-01 18:38:52 +01:00 committed by David Cole
parent e0bc42aa4f
commit f529ddcea0
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Tests/ExternalProject/CMakeLists.txt
View File

@ -343,13 +343,6 @@ endif()
# Only do svn tests with svn >= version 1.2 # Only do svn tests with svn >= version 1.2
# #
if(do_svn_tests) if(do_svn_tests)
execute_process(COMMAND ${Subversion_SVN_EXECUTABLE} --version
OUTPUT_VARIABLE Subversion_VERSION_SVN
OUTPUT_STRIP_TRAILING_WHITESPACE)
string(REGEX REPLACE "^(.*\n)?svn, version ([.0-9]+).*"
"\\2" Subversion_VERSION_SVN "${Subversion_VERSION_SVN}")
message(STATUS "Subversion_VERSION_SVN='${Subversion_VERSION_SVN}'")
if(Subversion_VERSION_SVN VERSION_LESS 1.2) if(Subversion_VERSION_SVN VERSION_LESS 1.2)
message(STATUS "No ExternalProject svn tests with svn client less than version 1.2") message(STATUS "No ExternalProject svn tests with svn client less than version 1.2")
set(do_svn_tests 0) set(do_svn_tests 0)