kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove old check for duplicate subdirectories 

In cmMakefile::AddSubDirectory we were checking for addition of the same
source directory multiple times.  However, the check code was incorrect
because it compared pointers instetad of pointed-to strings.  Since the
check was written, a better check was added right after it to enforce
unique binary directories (in which case duplicate sources are fine).
This commit simply removes the old-style check code.
This commit is contained in:
Brad King 2009-09-17 08:25:33 -04:00
parent ab64fba44f
commit ef8434284f
1 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Source/cmMakefile.cxx
View File

@ -1539,21 +1539,6 @@ void cmMakefile::AddSubDirectory(const char* srcPath, const char *binPath,
bool excludeFromAll, bool preorder,
bool immediate)
{
std::vector<cmLocalGenerator *>& children =
this->LocalGenerator->GetChildren();
// has this directory already been added? If so error
unsigned int i;
for (i = 0; i < children.size(); ++i)
{
if (srcPath == children[i]->GetMakefile()->GetStartDirectory())
{
cmSystemTools::Error
("Attempt to add subdirectory multiple times for directory.\n",
srcPath);
return;
}
}
// Make sure the binary directory is unique.
if(!this->EnforceUniqueDir(srcPath, binPath))
{