From deee7c42a2df8156ad81c371d0f1007286018f0f Mon Sep 17 00:00:00 2001 From: Zach Mullen Date: Tue, 27 May 2014 15:44:46 -0400 Subject: [PATCH] CTest: Fix Python coverage.py off-by-one error in results The cobertura format uses line numbers indexed starting at 1, and CTest uses a vector indexed starting at 0 to store them. --- Source/CTest/cmParsePythonCoverage.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/CTest/cmParsePythonCoverage.cxx b/Source/CTest/cmParsePythonCoverage.cxx index 68a6817af..817b8dca3 100644 --- a/Source/CTest/cmParsePythonCoverage.cxx +++ b/Source/CTest/cmParsePythonCoverage.cxx @@ -79,11 +79,11 @@ protected: curNumber = atoi(atts[tagCount+1]); } - if(curHits > -1 && curNumber > -1) + if(curHits > -1 && curNumber > 0) { FileLinesType& curFileLines = this->Coverage.TotalCoverage[this->CurFileName]; - curFileLines[curNumber] = curHits; + curFileLines[curNumber-1] = curHits; break; } ++tagCount;