kolan/CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cmSystemTools: Drop redundant condition in RunSingleCommand

Browse Source 
The output processing loop is already guarded by a condition so we do
not need to repeat the condition inside the loop.
This commit is contained in:
Brad King 2016-01-14 16:14:25 -05:00
parent ffa2a8c967
commit dc039cc02c
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Source/cmSystemTools.cxx
View File

@ -696,19 +696,17 @@ bool cmSystemTools::RunSingleCommand(std::vector<std::string>const& command,
{
while((pipe = cmsysProcess_WaitForData(cp, &data, &length, 0)) > 0)
{
if(captureStdOut || captureStdErr || outputflag != OUTPUT_NONE)
// Translate NULL characters in the output into valid text.
// Visual Studio 7 puts these characters in the output of its
// build process.
for(int i=0; i < length; ++i)
{
// Translate NULL characters in the output into valid text.
// Visual Studio 7 puts these characters in the output of its
// build process.
for(int i=0; i < length; ++i)
if(data[i] == '\0')
{
if(data[i] == '\0')
{
data[i] = ' ';
}
data[i] = ' ';
}
}
if(pipe == cmsysProcess_Pipe_STDOUT ||
(pipe == cmsysProcess_Pipe_STDERR &&
captureStdOut == captureStdErr))