kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

variable_watch: Remove undocumented and redundant access type 

The ALLOWED_UNKNOWN_VARIABLE_READ_ACCESS access type was switched on an
undocumented variable and its lookup caused an unnecessary performance
impact.  Remove it.
This commit is contained in:
Ben Boeckel 2014-05-05 17:25:24 -04:00 committed by Brad King
parent 96e9eb1766
commit d849800351
4 changed files with 9 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Help/release/dev/variable_watch-no-allowed-access.rst Normal file
View File

@ -0,0 +1,8 @@
variable_watch-no-allowed-access
--------------------------------
* Callbacks established by the :command:`variable_watch` command will no
longer receive the ``ALLOWED_UNKNOWN_READ_ACCESS`` access type when
the undocumented ``CMAKE_ALLOW_UNKNOWN_VARIABLE_READ_ACCESS`` variable is
set. Uninitialized variable accesses will always be reported as
``UNKNOWN_READ_ACCESS``.

11
Source/cmMakefile.cxx
View File

@ -2470,23 +2470,12 @@ const char* cmMakefile::GetDefinition(const std::string& name) const
vv->VariableAccessed(name, cmVariableWatch::VARIABLE_READ_ACCESS, vv->VariableAccessed(name, cmVariableWatch::VARIABLE_READ_ACCESS,
def, this); def, this);
} }
else
{
// are unknown access allowed
const char* allow = this->Internal->VarStack.top()
.Get("CMAKE_ALLOW_UNKNOWN_VARIABLE_READ_ACCESS");
if(cmSystemTools::IsOn(allow))
{
vv->VariableAccessed(name,
cmVariableWatch::ALLOWED_UNKNOWN_VARIABLE_READ_ACCESS, def, this);
}
else else
{ {
vv->VariableAccessed(name, vv->VariableAccessed(name,
cmVariableWatch::UNKNOWN_VARIABLE_READ_ACCESS, def, this); cmVariableWatch::UNKNOWN_VARIABLE_READ_ACCESS, def, this);
} }
} }
}
#endif #endif
return def; return def;
} }

1
Source/cmVariableWatch.cxx
View File

@ -16,7 +16,6 @@ static const char* const cmVariableWatchAccessStrings[] =
"READ_ACCESS", "READ_ACCESS",
"UNKNOWN_READ_ACCESS", "UNKNOWN_READ_ACCESS",
"UNKNOWN_DEFINED_ACCESS", "UNKNOWN_DEFINED_ACCESS",
"ALLOWED_UNKNOWN_READ_ACCESS",
"MODIFIED_ACCESS", "MODIFIED_ACCESS",
"REMOVED_ACCESS", "REMOVED_ACCESS",
"NO_ACCESS" "NO_ACCESS"

1
Source/cmVariableWatch.h
View File

@ -53,7 +53,6 @@ public:
VARIABLE_READ_ACCESS = 0, VARIABLE_READ_ACCESS = 0,
UNKNOWN_VARIABLE_READ_ACCESS, UNKNOWN_VARIABLE_READ_ACCESS,
UNKNOWN_VARIABLE_DEFINED_ACCESS, UNKNOWN_VARIABLE_DEFINED_ACCESS,
ALLOWED_UNKNOWN_VARIABLE_READ_ACCESS,
VARIABLE_MODIFIED_ACCESS, VARIABLE_MODIFIED_ACCESS,
VARIABLE_REMOVED_ACCESS, VARIABLE_REMOVED_ACCESS,
NO_ACCESS NO_ACCESS