kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge topic 'fix-read-after-free' 

5b2c2d2f Merge branch 'backport-fix-read-after-free' into fix-read-after-free
23ffb72a cmake: Fix read-after-free while checking command-line arguments
fe44f057 cmake: Fix read-after-free while checking command-line arguments
This commit is contained in:
Brad King 2014-06-13 15:45:07 -04:00 committed by CMake Topic Stage
parent 38befe3998 5b2c2d2fda
commit d7bbfa41f6
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
Source/cmake.cxx
View File

@ -343,16 +343,24 @@ bool cmake::SetCacheArgs(const std::vector<std::string>& args)
// The value is transformed if it is a filepath for example, so // The value is transformed if it is a filepath for example, so
// we can't compare whether the value is already in the cache until // we can't compare whether the value is already in the cache until
// after we call AddCacheEntry. // after we call AddCacheEntry.
const char *cachedValue = bool haveValue = false;
this->CacheManager->GetCacheValue(var); std::string cachedValue;
if(this->WarnUnusedCli)
{
if(const char *v = this->CacheManager->GetCacheValue(var))
{
haveValue = true;
cachedValue = v;
}
}
this->CacheManager->AddCacheEntry(var, value.c_str(), this->CacheManager->AddCacheEntry(var, value.c_str(),
"No help, variable specified on the command line.", type); "No help, variable specified on the command line.", type);
if(this->WarnUnusedCli) if(this->WarnUnusedCli)
{ {
if (!cachedValue if (!haveValue ||
|| strcmp(this->CacheManager->GetCacheValue(var), cachedValue != this->CacheManager->GetCacheValue(var))
cachedValue) != 0)
{ {
this->WatchUnusedCli(var); this->WatchUnusedCli(var);
} }