Run the unused variables check on the final pass
This commit is contained in:
parent
9efc05722e
commit
d784e6af4d
|
@ -828,6 +828,8 @@ void cmMakefile::ConfigureFinalPass()
|
||||||
{
|
{
|
||||||
l->second.FinishConfigure();
|
l->second.FinishConfigure();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
this->GetCMakeInstance()->RunCheckForUnusedVariables();
|
||||||
}
|
}
|
||||||
|
|
||||||
//----------------------------------------------------------------------------
|
//----------------------------------------------------------------------------
|
||||||
|
|
|
@ -201,21 +201,6 @@ cmake::cmake()
|
||||||
|
|
||||||
cmake::~cmake()
|
cmake::~cmake()
|
||||||
{
|
{
|
||||||
#ifdef CMAKE_BUILD_WITH_CMAKE
|
|
||||||
if(this->WarnUnusedCli)
|
|
||||||
{
|
|
||||||
std::map<std::string, bool>::const_iterator it;
|
|
||||||
for(it = this->UsedCliVariables.begin(); it != this->UsedCliVariables.end(); ++it)
|
|
||||||
{
|
|
||||||
if(!it->second)
|
|
||||||
{
|
|
||||||
std::string message = "warning: The variable, \"" + it->first + "\", given "
|
|
||||||
"on the command line, was not used within the build.";
|
|
||||||
cmSystemTools::Message(message.c_str());
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
#endif
|
|
||||||
delete this->CacheManager;
|
delete this->CacheManager;
|
||||||
delete this->Policies;
|
delete this->Policies;
|
||||||
if (this->GlobalGenerator)
|
if (this->GlobalGenerator)
|
||||||
|
@ -4500,3 +4485,22 @@ int cmake::Build(const std::string& dir,
|
||||||
config.c_str(), clean, false, 0, true,
|
config.c_str(), clean, false, 0, true,
|
||||||
0, nativeOptions);
|
0, nativeOptions);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
void cmake::RunCheckForUnusedVariables() const
|
||||||
|
{
|
||||||
|
#ifdef CMAKE_BUILD_WITH_CMAKE
|
||||||
|
if(this->WarnUnusedCli)
|
||||||
|
{
|
||||||
|
std::map<std::string, bool>::const_iterator it;
|
||||||
|
for(it = this->UsedCliVariables.begin(); it != this->UsedCliVariables.end(); ++it)
|
||||||
|
{
|
||||||
|
if(!it->second)
|
||||||
|
{
|
||||||
|
std::string message = "warning: The variable, \"" + it->first + "\", given "
|
||||||
|
"on the command line, was not used within the build.";
|
||||||
|
cmSystemTools::Message(message.c_str());
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
#endif
|
||||||
|
}
|
||||||
|
|
|
@ -362,6 +362,8 @@ class cmake
|
||||||
const std::string& config,
|
const std::string& config,
|
||||||
const std::vector<std::string>& nativeOptions,
|
const std::vector<std::string>& nativeOptions,
|
||||||
bool clean);
|
bool clean);
|
||||||
|
|
||||||
|
void RunCheckForUnusedVariables() const;
|
||||||
protected:
|
protected:
|
||||||
void InitializeProperties();
|
void InitializeProperties();
|
||||||
int HandleDeleteCacheVariables(const char* var);
|
int HandleDeleteCacheVariables(const char* var);
|
||||||
|
|
Loading…
Reference in New Issue