ENH: undo last change because it broke the dashboard

Source/kwsys/SystemTools.cxx

@@ -1922,11 +1922,7 @@ kwsys_stl::string SystemTools::FindProgram(
     {
     return "";
     }
-  bool extensionIncluded = false;
   kwsys_stl::string ext = SystemTools::GetExecutableExtension();
-  std::string searchName = name;
-  // check to see if the extension was included in the name
-  // if not, add it
   if(ext.size())
     {
     unsigned int len = strlen(name);
@@ -1934,72 +1930,85 @@ kwsys_stl::string SystemTools::FindProgram(
       {
       if(strcmp(name+(len-ext.size()), ext.c_str()) == 0)
         {
-        extensionIncluded = true;
+        ext = ""; // name already has Executable extension
         }
-      else
+      }
+    }
+  // See if the executable exists as written.
+  if(SystemTools::FileExists(name) &&
+      !SystemTools::FileIsDirectory(name))
     {
-        searchName += ext;
+    return SystemTools::CollapseFullPath(name);
     }
-      }
+  if(ext.size())
-    else
     {
-      searchName += ext;
+    kwsys_stl::string tryPath = name;
-      }
+    tryPath += ext;
-    }
+    if(SystemTools::FileExists(tryPath.c_str()) &&
-  // searchName now has the extension in it.
+       !SystemTools::FileIsDirectory(tryPath.c_str()))
-
-  // See if the executable exists as written
-  if(SystemTools::FileExists(searchName.c_str()) &&
-      !SystemTools::FileIsDirectory(searchName.c_str()))
       {
-    return SystemTools::CollapseFullPath(searchName.c_str());
+      return SystemTools::CollapseFullPath(tryPath.c_str());
+      }
     }
   kwsys_stl::vector<kwsys_stl::string> path;
-  // Add the system search path to our path if asked for
+  // Add the system search path to our path.
   if (!no_system_path)
     {
     SystemTools::GetPath(path);
     }
+
   // now add the additional paths
-  for(kwsys_stl::vector<kwsys_stl::string>::const_iterator i = 
+  for(kwsys_stl::vector<kwsys_stl::string>::const_iterator i = userPaths.begin();
-        userPaths.begin(); i != userPaths.end(); ++i)
+        i != userPaths.end(); ++i)
     {
     path.push_back(*i);
     }
-  kwsys_stl::string tryPath;
-  // now search the paths specified
   for(kwsys_stl::vector<kwsys_stl::string>::iterator p = path.begin();
       p != path.end(); ++p)
     {
 #ifdef _WIN32
     // Remove double quotes from the path on windows
     SystemTools::ReplaceString(*p, "\"", "");
-    // if the extension was not specified then look
+#endif
-    // for .com before the ext version
-    if(!extensionIncluded)
-      {
-      // first try .com instead .exe
     kwsys_stl::string tryPath = *p;
     tryPath += "/";
-      tryPath += searchName;
+    tryPath += name;
+    if(SystemTools::FileExists(tryPath.c_str()) &&
+      !SystemTools::FileIsDirectory(tryPath.c_str()))
+      {
+      return SystemTools::CollapseFullPath(tryPath.c_str());
+      }
+#ifdef _WIN32
+    // on windows try .com before .exe
+    if(ext.size() == 0)
+      {
       SystemTools::ReplaceString(tryPath, ".exe", ".com");
       SystemTools::ReplaceString(tryPath, ".EXE", ".com");
+      }
+    else
+      {
+      tryPath += ".com";
+      }
     if(SystemTools::FileExists(tryPath.c_str()) &&
        !SystemTools::FileIsDirectory(tryPath.c_str()))
       {
       return SystemTools::CollapseFullPath(tryPath.c_str());
       }
-      }
 #endif
+    // now try to add ext if it is different than name
+    if(ext.size())
+      {
       tryPath = *p;
       tryPath += "/";
-    tryPath += searchName;
+      tryPath += name;
+      tryPath += ext;
       if(SystemTools::FileExists(tryPath.c_str()) &&
          !SystemTools::FileIsDirectory(tryPath.c_str()))
         {
         return SystemTools::CollapseFullPath(tryPath.c_str());
         }
       }
+    }
 
   // Couldn't find the program.
   return "";