From cd344e3a62e3a6728e5b749cb923104c2c09949c Mon Sep 17 00:00:00 2001 From: Sylvain Joubert Date: Thu, 25 Aug 2016 11:54:28 +0200 Subject: [PATCH] create_test_sourcelist: Use safer strncpy instead of strcpy Clang-tidy advises to use a safer function in place of strcpy. This should avoid such warnings in user build using clang-tidy. --- Templates/TestDriver.cxx.in | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Templates/TestDriver.cxx.in b/Templates/TestDriver.cxx.in index ffa69995b..3e0afa50a 100644 --- a/Templates/TestDriver.cxx.in +++ b/Templates/TestDriver.cxx.in @@ -33,19 +33,21 @@ static functionMapEntry cmakeGeneratedFunctionMapEntries[] = { static char* lowercase(const char *string) { char *new_string, *p; + size_t stringSize = 0; #ifdef __cplusplus - new_string = static_cast(malloc(sizeof(char) * - static_cast(strlen(string) + 1))); + stringSize = static_cast(strlen(string) + 1); + new_string = static_cast(malloc(sizeof(char) * stringSize)); #else - new_string = (char *)(malloc(sizeof(char) * (size_t)(strlen(string) + 1))); + stringSize = (size_t)(strlen(string) + 1); + new_string = (char *)(malloc(sizeof(char) * stringSize)); #endif if (!new_string) { return 0; } - strcpy(new_string, string); + strncpy(new_string, string, stringSize); p = new_string; while (*p != 0) {