kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Make target_link_libraries() complain if bad target name is used 

target_link_libraries() did not complain if there was only one argument,
and this one (first) argument wasn't a valid target name, e.g.

add_executable(hello main.cpp)
target_link_libraries(-static-intel)

Here the target "hello" was forgotten in the tll() call, but cmake didn't
complain. With this commit it does.

Alex
This commit is contained in:
Alex Neundorf 2010-08-26 21:02:40 +02:00
parent 43f96eaf93
commit c786635149
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Source/cmTargetLinkLibrariesCommand.cxx
View File

@ -29,12 +29,6 @@ bool cmTargetLinkLibrariesCommand
return false; return false;
} }
// but we might not have any libs after variable expansion
if(args.size() < 2)
{
return true;
}
// Lookup the target for which libraries are specified. // Lookup the target for which libraries are specified.
this->Target = this->Target =
this->Makefile->GetCMakeInstance() this->Makefile->GetCMakeInstance()
@ -49,6 +43,12 @@ bool cmTargetLinkLibrariesCommand
return true; return true;
} }
// but we might not have any libs after variable expansion
if(args.size() < 2)
{
return true;
}
// Keep track of link configuration specifiers. // Keep track of link configuration specifiers.
cmTarget::LinkLibraryType llt = cmTarget::GENERAL; cmTarget::LinkLibraryType llt = cmTarget::GENERAL;
bool haveLLT = false; bool haveLLT = false;