kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

BUG: Removed some code which was squashing Boost_LIBRARIES on WIN32 under the auspices of forcing the user to use autolinking, but it only did this squashing on the first call to FindBoost. Subsequent calls to FindBoost would not have Boost_LIBRARIES squashed so this code was doing nothing. If you link your target_link_libraries() against dynamic boost libraries it appears from tools like Dependency Walker that the pragma calls to autolink to the static boost libraries are ignored. It's therefore too late to make this squash apply to all calls to FindBoost because that would break users that have not setup autolinking properly. For now this fix is largely cosmetic since the original code never worked anyways (see version 1.5 introduced on 4/22/08).

This commit is contained in:
Philip Lowman 2009-01-18 15:41:18 -05:00
parent 909dd8af48
commit c4e85549c9
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Modules/FindBoost.cmake
View File

@ -792,13 +792,6 @@ ELSE (_boost_IN_CACHE)
ENDIF(Boost_FIND_REQUIRED)
ENDIF(Boost_FOUND)
# Under Windows, automatic linking is performed, so no need to specify the libraries.
IF (WIN32)
IF (NOT MINGW)
SET(Boost_LIBRARIES "")
ENDIF (NOT MINGW)
ENDIF(WIN32)
# show the Boost_INCLUDE_DIRS AND Boost_LIBRARIES variables only in the advanced view
MARK_AS_ADVANCED(Boost_INCLUDE_DIR
Boost_INCLUDE_DIRS