From b5265c24751dd89487d71f8cb5e735e7a9eab1f9 Mon Sep 17 00:00:00 2001 From: David Cole Date: Mon, 28 Sep 2009 17:35:40 -0400 Subject: [PATCH] Fix issue #9395 - only return true for .exe files on Windows from the is_file_executable function. Makes behavior of this function conceptually consistent with Mac and Linux behavior. Thanks to Clinton Stimpson for the patch. --- Modules/GetPrerequisites.cmake | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Modules/GetPrerequisites.cmake b/Modules/GetPrerequisites.cmake index b7656a375..67d4a1416 100644 --- a/Modules/GetPrerequisites.cmake +++ b/Modules/GetPrerequisites.cmake @@ -73,16 +73,16 @@ function(is_file_executable file result_var) get_filename_component(file_full "${file}" ABSOLUTE) string(TOLOWER "${file_full}" file_full_lower) - # If file name ends in .exe or .dll on Windows, *assume* executable: + # If file name ends in .exe on Windows, *assume* executable: # if(WIN32) - if("${file_full_lower}" MATCHES "\\.(exe|dll)$") + if("${file_full_lower}" MATCHES "\\.exe$") set(${result_var} 1 PARENT_SCOPE) return() - endif("${file_full_lower}" MATCHES "\\.(exe|dll)$") + endif("${file_full_lower}" MATCHES "\\.exe$") # A clause could be added here that uses output or return value of dumpbin - # to determine ${result_var}. In 99%+? practical cases, the exe|dll name + # to determine ${result_var}. In 99%+? practical cases, the exe name # match will be sufficient... # endif(WIN32)