Replace !foo.size() pattern with foo.empty().

This commit is contained in:
Stephen Kelly 2015-01-15 23:13:44 +01:00
parent 6459263377
commit aa773035b7
7 changed files with 13 additions and 13 deletions

View File

@ -193,7 +193,7 @@ public:
int cmCTestBuildAndTestHandler::RunCMakeAndTest(std::string* outstring)
{
// if the generator and make program are not specified then it is an error
if (!this->BuildGenerator.size())
if (this->BuildGenerator.empty())
{
if(outstring)
{
@ -329,7 +329,7 @@ int cmCTestBuildAndTestHandler::RunCMakeAndTest(std::string* outstring)
}
// if no test was specified then we are done
if (!this->TestCommand.size())
if (this->TestCommand.empty())
{
return 0;
}

View File

@ -1311,7 +1311,7 @@ int cmCTestCoverageHandler::HandleGCovCoverage(
//TODO: Handle gcov 3.0 non-coverage lines
// Skip empty lines
if ( !nl.size() )
if (nl.empty())
{
continue;
}
@ -1627,7 +1627,7 @@ int cmCTestCoverageHandler::HandleLCovCoverage(
cnt ++;
// Skip empty lines
if ( !nl.size() )
if (nl.empty())
{
continue;
}
@ -1813,7 +1813,7 @@ int cmCTestCoverageHandler::HandleTracePyCoverage(
cnt ++;
// Skip empty lines
if ( !nl.size() )
if (nl.empty())
{
continue;
}

View File

@ -812,8 +812,8 @@ bool cmCTestSubmitHandler::SubmitUsingSCP(
const std::string& remoteprefix,
const std::string& url)
{
if ( !scp_command.size() || !localprefix.size() ||
!files.size() || !remoteprefix.size() || !url.size() )
if ( scp_command.empty() || localprefix.empty() ||
files.empty() || remoteprefix.empty() || url.empty() )
{
return 0;
}
@ -912,8 +912,8 @@ bool cmCTestSubmitHandler::SubmitUsingCP(
const std::string& remoteprefix,
const std::string& destination)
{
if ( !localprefix.size() ||
!files.size() || !remoteprefix.size() || !destination.size() )
if ( localprefix.empty() ||
files.empty() || remoteprefix.empty() || destination.empty() )
{
cmCTestLog(this->CTest, ERROR_MESSAGE,
"Missing arguments for submit via cp:\n"

View File

@ -37,7 +37,7 @@ bool cmAddSubDirectoryCommand::InitialPass
excludeFromAll = true;
continue;
}
else if (!binArg.size())
else if (binArg.empty())
{
binArg = *i;
}

View File

@ -597,7 +597,7 @@ void cmGlobalUnixMakefileGenerator3
tname = lg->Convert(tname,cmLocalGenerator::HOME_OUTPUT);
cmSystemTools::ConvertToOutputSlashes(tname);
makeCommand.push_back(tname);
if (!this->LocalGenerators.size())
if (this->LocalGenerators.empty())
{
delete lg;
}

View File

@ -523,7 +523,7 @@ cmInstallTargetGenerator
std::string installNameTool =
this->Target->GetMakefile()->GetSafeDefinition("CMAKE_INSTALL_NAME_TOOL");
if(!installNameTool.size())
if(installNameTool.empty())
{
return;
}

View File

@ -898,7 +898,7 @@ bool cmStringCommand
}
}
}
if ( !alphabet.size() )
if (alphabet.empty())
{
alphabet = cmStringCommandDefaultAlphabet;
}