export(): Handle multiple dependent export sets.
The export-sets topic, merged in commit 49c7b649
(Merge topic
'export-sets', 2012-10-01) changed install(EXPORT) to allow
exporting targets whose dependents are exported separately
to different locations. Doing the same for export() was not
possible because the export() command was executed at
configure-time.
Now that export() is also executed at generate-time, make it
possible to export to multiple dependent export sets.
This commit is contained in:
parent
66b290e7e2
commit
a4263c9f64
|
@ -11,6 +11,8 @@
|
||||||
============================================================================*/
|
============================================================================*/
|
||||||
#include "cmExportBuildFileGenerator.h"
|
#include "cmExportBuildFileGenerator.h"
|
||||||
|
|
||||||
|
#include "cmLocalGenerator.h"
|
||||||
|
#include "cmGlobalGenerator.h"
|
||||||
|
|
||||||
//----------------------------------------------------------------------------
|
//----------------------------------------------------------------------------
|
||||||
cmExportBuildFileGenerator::cmExportBuildFileGenerator()
|
cmExportBuildFileGenerator::cmExportBuildFileGenerator()
|
||||||
|
@ -194,27 +196,72 @@ cmExportBuildFileGenerator
|
||||||
//----------------------------------------------------------------------------
|
//----------------------------------------------------------------------------
|
||||||
void
|
void
|
||||||
cmExportBuildFileGenerator::HandleMissingTarget(
|
cmExportBuildFileGenerator::HandleMissingTarget(
|
||||||
std::string& link_libs, std::vector<std::string>&,
|
std::string& link_libs, std::vector<std::string>& missingTargets,
|
||||||
cmMakefile*, cmTarget* depender, cmTarget* dependee)
|
cmMakefile* mf, cmTarget* depender, cmTarget* dependee)
|
||||||
{
|
{
|
||||||
// The target is not in the export.
|
// The target is not in the export.
|
||||||
if(!this->AppendMode)
|
if(!this->AppendMode)
|
||||||
{
|
{
|
||||||
// We are not appending, so all exported targets should be
|
const std::string name = dependee->GetName();
|
||||||
// known here. This is probably user-error.
|
std::vector<std::string> namespaces = this->FindNamespaces(mf, name);
|
||||||
this->ComplainAboutMissingTarget(depender, dependee);
|
|
||||||
|
int targetOccurrences = (int)namespaces.size();
|
||||||
|
if (targetOccurrences == 1)
|
||||||
|
{
|
||||||
|
std::string missingTarget = namespaces[0];
|
||||||
|
|
||||||
|
missingTarget += dependee->GetExportName();
|
||||||
|
link_libs += missingTarget;
|
||||||
|
missingTargets.push_back(missingTarget);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
// We are not appending, so all exported targets should be
|
||||||
|
// known here. This is probably user-error.
|
||||||
|
this->ComplainAboutMissingTarget(depender, dependee, targetOccurrences);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
// Assume the target will be exported by another command.
|
// Assume the target will be exported by another command.
|
||||||
// Append it with the export namespace.
|
// Append it with the export namespace.
|
||||||
link_libs += this->Namespace;
|
link_libs += this->Namespace;
|
||||||
link_libs += dependee->GetExportName();
|
link_libs += dependee->GetExportName();
|
||||||
|
// if generate time {}
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
//----------------------------------------------------------------------------
|
||||||
|
std::vector<std::string>
|
||||||
|
cmExportBuildFileGenerator
|
||||||
|
::FindNamespaces(cmMakefile* mf, const std::string& name)
|
||||||
|
{
|
||||||
|
std::vector<std::string> namespaces;
|
||||||
|
cmGlobalGenerator* gg = mf->GetLocalGenerator()->GetGlobalGenerator();
|
||||||
|
|
||||||
|
std::map<std::string, cmExportBuildFileGenerator*>& exportSets
|
||||||
|
= gg->GetBuildExportSets();
|
||||||
|
|
||||||
|
for(std::map<std::string, cmExportBuildFileGenerator*>::const_iterator
|
||||||
|
expIt = exportSets.begin(); expIt != exportSets.end(); ++expIt)
|
||||||
|
{
|
||||||
|
const cmExportBuildFileGenerator* exportSet = expIt->second;
|
||||||
|
std::vector<std::string> const& targets = exportSet->GetTargets();
|
||||||
|
|
||||||
|
if (std::find(targets.begin(), targets.end(), name) != targets.end())
|
||||||
|
{
|
||||||
|
namespaces.push_back(exportSet->GetNamespace());
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return namespaces;
|
||||||
}
|
}
|
||||||
|
|
||||||
//----------------------------------------------------------------------------
|
//----------------------------------------------------------------------------
|
||||||
void
|
void
|
||||||
cmExportBuildFileGenerator
|
cmExportBuildFileGenerator
|
||||||
::ComplainAboutMissingTarget(cmTarget* depender,
|
::ComplainAboutMissingTarget(cmTarget* depender,
|
||||||
cmTarget* dependee)
|
cmTarget* dependee,
|
||||||
|
int occurrences)
|
||||||
{
|
{
|
||||||
if(cmSystemTools::GetErrorOccuredFlag())
|
if(cmSystemTools::GetErrorOccuredFlag())
|
||||||
{
|
{
|
||||||
|
@ -223,9 +270,17 @@ cmExportBuildFileGenerator
|
||||||
|
|
||||||
cmOStringStream e;
|
cmOStringStream e;
|
||||||
e << "export called with target \"" << depender->GetName()
|
e << "export called with target \"" << depender->GetName()
|
||||||
<< "\" which requires target \"" << dependee->GetName()
|
<< "\" which requires target \"" << dependee->GetName() << "\" ";
|
||||||
<< "\" that is not in the export list.\n"
|
if (occurrences == 0)
|
||||||
<< "If the required target is not easy to reference in this call, "
|
{
|
||||||
|
e << "that is not in the export set.\n";
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
e << "that is not in this export set, but " << occurrences
|
||||||
|
<< " times in others.\n";
|
||||||
|
}
|
||||||
|
e << "If the required target is not easy to reference in this call, "
|
||||||
<< "consider using the APPEND option with multiple separate calls.";
|
<< "consider using the APPEND option with multiple separate calls.";
|
||||||
|
|
||||||
this->Makefile->GetCMakeInstance()
|
this->Makefile->GetCMakeInstance()
|
||||||
|
|
|
@ -60,7 +60,8 @@ protected:
|
||||||
cmTarget* dependee);
|
cmTarget* dependee);
|
||||||
|
|
||||||
void ComplainAboutMissingTarget(cmTarget* depender,
|
void ComplainAboutMissingTarget(cmTarget* depender,
|
||||||
cmTarget* dependee);
|
cmTarget* dependee,
|
||||||
|
int occurrences);
|
||||||
|
|
||||||
/** Fill in properties indicating built file locations. */
|
/** Fill in properties indicating built file locations. */
|
||||||
void SetImportLocationProperty(const char* config,
|
void SetImportLocationProperty(const char* config,
|
||||||
|
@ -70,6 +71,9 @@ protected:
|
||||||
|
|
||||||
std::string InstallNameDir(cmTarget* target, const std::string& config);
|
std::string InstallNameDir(cmTarget* target, const std::string& config);
|
||||||
|
|
||||||
|
std::vector<std::string>
|
||||||
|
FindNamespaces(cmMakefile* mf, const std::string& name);
|
||||||
|
|
||||||
std::vector<std::string> Targets;
|
std::vector<std::string> Targets;
|
||||||
std::vector<cmTarget*> Exports;
|
std::vector<cmTarget*> Exports;
|
||||||
cmMakefile* Makefile;
|
cmMakefile* Makefile;
|
||||||
|
|
Loading…
Reference in New Issue