From a271f7f17707c50744c2dbeb20ae82b10c886f4f Mon Sep 17 00:00:00 2001
From: Stephen Kelly <steveire@gmail.com>
Date: Mon, 18 May 2015 22:10:59 +0200
Subject: [PATCH] cmTarget: Simplify CMP0023 message loop.

This method is only called if there is a mismatch and something to
print.  Remove intermediate container.
---
 Source/cmTarget.cxx | 20 +++++---------------
 1 file changed, 5 insertions(+), 15 deletions(-)

diff --git a/Source/cmTarget.cxx b/Source/cmTarget.cxx
index e705aaa48..8feb7a522 100644
--- a/Source/cmTarget.cxx
+++ b/Source/cmTarget.cxx
@@ -1251,27 +1251,17 @@ bool cmTarget::PushTLLCommandTrace(TLLSignature signature)
 void cmTarget::GetTllSignatureTraces(std::ostringstream &s,
                                      TLLSignature sig) const
 {
-  std::vector<cmListFileContext> sigs;
+  const char *sigString = (sig == cmTarget::KeywordTLLSignature ? "keyword"
+                                                                : "plain");
+  s << "The uses of the " << sigString << " signature are here:\n";
   typedef std::vector<std::pair<TLLSignature, cmListFileContext> > Container;
+  cmLocalGenerator* lg = this->GetMakefile()->GetLocalGenerator();
   for(Container::const_iterator it = this->TLLCommands.begin();
       it != this->TLLCommands.end(); ++it)
     {
     if (it->first == sig)
       {
-      sigs.push_back(it->second);
-      }
-    }
-  cmLocalGenerator* lg = this->GetMakefile()->GetLocalGenerator();
-  if (!sigs.empty())
-    {
-    const char *sigString
-                        = (sig == cmTarget::KeywordTLLSignature ? "keyword"
-                                                                : "plain");
-    s << "The uses of the " << sigString << " signature are here:\n";
-    for(std::vector<cmListFileContext>::iterator it = sigs.begin();
-        it != sigs.end(); ++it)
-      {
-      cmListFileContext lfc = *it;
+      cmListFileContext lfc = it->second;
       lfc.FilePath = lg->Convert(lfc.FilePath, cmLocalGenerator::HOME);
       s << " * " << lfc << std::endl;
       }