kolan/CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ExternalProject: Remove 'unknown keyword' warning (#11034)

Browse Source 
The intent was to warn about misspelled keyword arguments,
but the effect was to warn about valid argument values far
too often. Let's stop annoying and confusing people.
This commit is contained in:
David Cole 2010-07-28 08:16:08 -04:00
parent 13d686331e
commit 9fa49dc3ad
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Modules/ExternalProject.cmake
View File

@ -154,8 +154,8 @@ function(_ep_parse_arguments f name ns args)
# correctly based on target properties. # correctly based on target properties.
# #
# We loop through ARGN and consider the namespace starting with an # We loop through ARGN and consider the namespace starting with an
# upper-case letter followed by at least two more upper-case letters # upper-case letter followed by at least two more upper-case letters,
# or underscores to be keywords. # numbers or underscores to be keywords.
set(key) set(key)
foreach(arg IN LISTS args) foreach(arg IN LISTS args)
@ -166,14 +166,6 @@ function(_ep_parse_arguments f name ns args)
NOT arg MATCHES "^(TRUE|FALSE)$") NOT arg MATCHES "^(TRUE|FALSE)$")
if(_ep_keywords_${f} AND arg MATCHES "${_ep_keywords_${f}}") if(_ep_keywords_${f} AND arg MATCHES "${_ep_keywords_${f}}")
set(is_value 0) set(is_value 0)
else()
if(NOT (key STREQUAL "COMMAND")
AND NOT (key STREQUAL "CVS_MODULE")
AND NOT (key STREQUAL "DEPENDS")
AND NOT (key STREQUAL "DOWNLOAD_COMMAND")
)
message(AUTHOR_WARNING "unknown ${f} keyword: ${arg}")
endif()
endif() endif()
endif() endif()