From 9f49ac3df0f0324d72daa54e2c005c30f4d74414 Mon Sep 17 00:00:00 2001 From: "Alan W. Irwin" Date: Mon, 8 Sep 2014 12:24:17 -0700 Subject: [PATCH] ExternalProject: Avoid infinite loop on file download hash mismatch When the loop was added by commit v3.0.0-rc1~103^2~3 (ExternalProject: Reattempt download when verification fails, 2015-01-15), we forgot to actually increment the loop counter. Add the increment line. --- Modules/ExternalProject.cmake | 1 + 1 file changed, 1 insertion(+) diff --git a/Modules/ExternalProject.cmake b/Modules/ExternalProject.cmake index 17cb866d3..a1c7629cd 100644 --- a/Modules/ExternalProject.cmake +++ b/Modules/ExternalProject.cmake @@ -607,6 +607,7 @@ Retrying download. file(REMOVE \"\${file}\") execute_process(COMMAND \${CMAKE_COMMAND} -P \"${download_script}\") endif() + math(EXPR attempt \"\${attempt} + 1\") endwhile() if(\${succeeded})