kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cmake-mode.el: Fix help completion item lists with CMake >= 3.0 (#16019) 

We run `cmake --help-*-list` to get a list of items for completion.
Since CMake < 3.0 always printed "cmake version ..." on the first line
of the output we have previously ignored the first line.  However, CMake
3.0 and above do not print the version line so we should not ignore the
first line or we miss one item.

Ideally we should filter the first line out if it is "cmake version ..."
in order to support CMake < 3.0 cleanly, but at worst the version line
will show up as a completion option so simply including the first line
is good enough for now.
This commit is contained in:
Julian Schmidt 2016-03-15 09:39:58 -04:00 committed by Brad King
parent a87253154e
commit 9dc384f662
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Auxiliary/cmake-mode.el
View File

@ -304,7 +304,8 @@ and store the result as a list in LISTVAR."
(save-window-excursion (save-window-excursion
(cmake-command-run (concat "--help-" listname "-list") nil temp-buffer-name) (cmake-command-run (concat "--help-" listname "-list") nil temp-buffer-name)
(with-current-buffer temp-buffer-name (with-current-buffer temp-buffer-name
(set listvar (cdr (split-string (buffer-substring-no-properties (point-min) (point-max)) "\n" t)))))) ; FIXME: Ignore first line if it is "cmake version ..." from CMake < 3.0.
(set listvar (split-string (buffer-substring-no-properties (point-min) (point-max)) "\n" t)))))
(symbol-value listvar) (symbol-value listvar)
)) ))
) )