cmake-mode.el: Replace 'setq' with 'let' or inlining

This commit is contained in:
Philipp Möller 2014-01-28 18:05:21 +01:00 committed by Brad King
parent d3db7126e6
commit 9b3876bfbc
1 changed files with 23 additions and 22 deletions

View File

@ -276,8 +276,9 @@ optional argument topic will be appended to the argument list."
(if buffer (if buffer
(display-buffer buffer 'not-this-window) (display-buffer buffer 'not-this-window)
;; Buffer doesn't exist. Create it and fill it ;; Buffer doesn't exist. Create it and fill it
(setq buffer (generate-new-buffer bufname)) (let ((buffer (generate-new-buffer bufname))
(setq command (concat cmake-mode-cmake-executable " " type " " topic)) (command (concat cmake-mode-cmake-executable " " type " " topic))
)
(message "Running %s" command) (message "Running %s" command)
;; We don't want the contents of the shell-command running to the ;; We don't want the contents of the shell-command running to the
;; minibuffer, so turn it off. A value of nil means don't automatically ;; minibuffer, so turn it off. A value of nil means don't automatically
@ -298,6 +299,7 @@ optional argument topic will be appended to the argument list."
) )
) )
) )
)
;;;###autoload ;;;###autoload
(defun cmake-help-list-commands () (defun cmake-help-list-commands ()
@ -330,9 +332,8 @@ optional argument topic will be appended to the argument list."
(defun cmake-help-command () (defun cmake-help-command ()
"Prints out the help message corresponding to the command the cursor is on." "Prints out the help message corresponding to the command the cursor is on."
(interactive) (interactive)
(setq command (cmake-get-topic "command")) (cmake-command-run "--help-command" (downcase (cmake-get-topic "command"))))
(cmake-command-run "--help-command" (downcase command))
)
;;;###autoload ;;;###autoload
(progn (progn