From 751f7b5255d861abc3105d3d971164293b3dec60 Mon Sep 17 00:00:00 2001 From: Ruslan Baratov Date: Sat, 10 Sep 2016 00:39:26 +0300 Subject: [PATCH 1/2] string(TIMESTAMP ...): add '%a' and '%b' format specifiers %b: Abbreviated month name (e.g. Oct). %a: Abbreviated weekday name (e.g. Fri). --- Help/command/string.rst | 2 ++ Source/cmTimestamp.cxx | 2 ++ .../CMakeTests/String-TIMESTAMP-MonthWeekNames.cmake | 11 +++++++++++ Tests/CMakeTests/StringTest.cmake.in | 3 +++ 4 files changed, 18 insertions(+) create mode 100644 Tests/CMakeTests/String-TIMESTAMP-MonthWeekNames.cmake diff --git a/Help/command/string.rst b/Help/command/string.rst index 19a095aed..802833328 100644 --- a/Help/command/string.rst +++ b/Help/command/string.rst @@ -278,12 +278,14 @@ specifiers: %I The hour on a 12-hour clock (01-12). %j The day of the current year (001-366). %m The month of the current year (01-12). + %b Abbreviated month name (e.g. Oct). %M The minute of the current hour (00-59). %s Seconds since midnight (UTC) 1-Jan-1970 (UNIX time). %S The second of the current minute. 60 represents a leap second. (00-60) %U The week number of the current year (00-53). %w The day of the current week. 0 is Sunday. (0-6) + %a Abbreviated weekday name (e.g. Fri). %y The last two digits of the current year (00-99) %Y The current year. diff --git a/Source/cmTimestamp.cxx b/Source/cmTimestamp.cxx index 61b74dbdf..a94212c92 100644 --- a/Source/cmTimestamp.cxx +++ b/Source/cmTimestamp.cxx @@ -123,6 +123,8 @@ std::string cmTimestamp::AddTimestampComponent(char flag, formatString += flag; switch (flag) { + case 'a': + case 'b': case 'd': case 'H': case 'I': diff --git a/Tests/CMakeTests/String-TIMESTAMP-MonthWeekNames.cmake b/Tests/CMakeTests/String-TIMESTAMP-MonthWeekNames.cmake new file mode 100644 index 000000000..1cd44ffff --- /dev/null +++ b/Tests/CMakeTests/String-TIMESTAMP-MonthWeekNames.cmake @@ -0,0 +1,11 @@ +string(TIMESTAMP output "%a;%b") +message("~${output}~") + +list(LENGTH output output_length) + +set(expected_output_length 2) + +if(NOT output_length EQUAL ${expected_output_length}) + message(FATAL_ERROR "expected ${expected_output_length} entries in output " + "with all specifiers; found ${output_length}") +endif() diff --git a/Tests/CMakeTests/StringTest.cmake.in b/Tests/CMakeTests/StringTest.cmake.in index aba35fe5f..a45b2056e 100644 --- a/Tests/CMakeTests/StringTest.cmake.in +++ b/Tests/CMakeTests/StringTest.cmake.in @@ -36,6 +36,8 @@ set(TIMESTAMP-IncompleteSpecifier-RESULT 0) set(TIMESTAMP-IncompleteSpecifier-STDERR "~foobar%~") set(TIMESTAMP-AllSpecifiers-RESULT 0) set(TIMESTAMP-AllSpecifiers-STDERR "~[0-9]+(;[0-9]+)*~") +set(TIMESTAMP-MonthWeekNames-RESULT 0) +set(TIMESTAMP-MonthWeekNames-STDERR "~[^%]+;[^%]+~") set(TIMESTAMP-UnixTime-RESULT 0) set(TIMESTAMP-UnixTime-STDERR "~[1-9][0-9]+~") @@ -60,6 +62,7 @@ check_cmake_test(String TIMESTAMP-UnknownSpecifier TIMESTAMP-IncompleteSpecifier TIMESTAMP-AllSpecifiers + TIMESTAMP-MonthWeekNames TIMESTAMP-UnixTime ) From 410add400803340581eccf5ac1c83c8d4e40ad5a Mon Sep 17 00:00:00 2001 From: Brad King Date: Mon, 12 Sep 2016 15:15:50 -0400 Subject: [PATCH 2/2] Help: Add notes for topic 'timestamp-names' --- Help/release/dev/timestamp-names.rst | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 Help/release/dev/timestamp-names.rst diff --git a/Help/release/dev/timestamp-names.rst b/Help/release/dev/timestamp-names.rst new file mode 100644 index 000000000..ea54b5cf4 --- /dev/null +++ b/Help/release/dev/timestamp-names.rst @@ -0,0 +1,6 @@ +timestamp-names +--------------- + +* The :command:`string(TIMESTAMP)` and :command:`file(TIMESTAMP)` + commands gained support for the ``%a`` and ``%b`` placeholders. + These are the abbreviated weekday and month names.