From 92b835ec9d17b190b13da93702f0eb416b665a48 Mon Sep 17 00:00:00 2001 From: Brad King Date: Mon, 24 Aug 2015 10:58:42 -0400 Subject: [PATCH] Simplify condition for using rpcrt4 library on Windows Drop the CMAKE_BUILD_ON_VISUAL_STUDIO variable and hard-code the condition at its only use. --- CMakeLists.txt | 11 ----------- Source/CMakeLists.txt | 4 ++-- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 36244dd45..5e13a7e0f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -144,17 +144,6 @@ macro(CMAKE_HANDLE_SYSTEM_LIBRARIES) endmacro() - - - -if(NOT CMake_TEST_EXTERNAL_CMAKE) - set(CMAKE_BUILD_ON_VISUAL_STUDIO 0) - if(WIN32 AND NOT UNIX AND NOT MINGW) - set(CMAKE_BUILD_ON_VISUAL_STUDIO 1) - endif() -endif() - - #----------------------------------------------------------------------- # a macro to determine the generator and ctest executable to use # for testing. Simply to improve readability of the main script. diff --git a/Source/CMakeLists.txt b/Source/CMakeLists.txt index 428b3648d..1886519cf 100644 --- a/Source/CMakeLists.txt +++ b/Source/CMakeLists.txt @@ -556,8 +556,8 @@ if(APPLE) target_link_libraries(CMakeLib "-framework CoreFoundation") endif() -if(CMAKE_BUILD_ON_VISUAL_STUDIO OR MINGW) - # We need the rpcrt4 library for at least the VS7-VC10 generators. +if(WIN32 AND NOT UNIX) + # We need the rpcrt4 library on Windows. target_link_libraries(CMakeLib rpcrt4) endif()