From 873f21ad1bcbf900025b7cbddb50b94b37d198aa Mon Sep 17 00:00:00 2001 From: Brad King Date: Tue, 17 Jul 2012 08:16:12 -0400 Subject: [PATCH] pre-commit: Reject C++ code with lines too long Check changes in Source/*.h and Source/*.cxx for lines longer than our style limit. --- Utilities/Git/pre-commit | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/Utilities/Git/pre-commit b/Utilities/Git/pre-commit index 110e9ee35..d308a81b5 100755 --- a/Utilities/Git/pre-commit +++ b/Utilities/Git/pre-commit @@ -19,6 +19,26 @@ die() { exit 1 } +#------------------------------------------------------------------------------- +line_too_long=80 +bad=$(regex=".{$line_too_long}" && +git diff-index --cached HEAD --name-only --diff-filter=AM \ + --pickaxe-regex -S"$regex" -- 'Source/*.h' 'Source/*.cxx' | +while read file; do + lines_too_long=$(git diff-index -p --cached HEAD \ + --pickaxe-regex -S"$regex" -- "$file") + if echo "$lines_too_long" | egrep -q '^\+'"$regex"; then + echo "$lines_too_long" + fi +done) +test -z "$bad" || +die 'The following changes add lines too long for our C++ style: + +'"$bad"' + +Use lines strictly less than '"$line_too_long"' characters in C++ code.' + +#------------------------------------------------------------------------------- if test -z "$HOOKS_ALLOW_KWSYS"; then # Disallow changes to KWSys files=$(git diff-index --name-only --cached HEAD -- Source/kwsys) &&