kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cmRemoveDuplicates: Partially specialize the API for pointer types. 

If de-duplicating a container of pointers, there is no need to
store iterators to them, as that is just more 'pointer chasing'.

Store the pointers themselves and use API which compares the pointers
in the specialization.
This commit is contained in:
Stephen Kelly 2015-03-08 09:43:11 +01:00
parent eec7091d76
commit 8701a3f468
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Source/cmAlgorithms.h
View File

@ -263,7 +263,7 @@ typename Range::const_iterator cmRemoveMatching(Range &r, MatchRange const& m)
namespace ContainerAlgorithms { namespace ContainerAlgorithms {
template<typename Range> template<typename Range, typename T = typename Range::value_type>
struct RemoveDuplicatesAPI struct RemoveDuplicatesAPI
{ {
typedef typename Range::const_iterator const_iterator; typedef typename Range::const_iterator const_iterator;
@ -275,6 +275,18 @@ struct RemoveDuplicatesAPI
static bool valueCompare(It it, const_iterator it2) { return **it != *it2; } static bool valueCompare(It it, const_iterator it2) { return **it != *it2; }
}; };
template<typename Range, typename T>
struct RemoveDuplicatesAPI<Range, T*>
{
typedef typename Range::const_iterator const_iterator;
typedef T* value_type;
static bool lessThan(value_type a, value_type b) { return a < b; }
static value_type uniqueValue(const_iterator a) { return *a; }
template<typename It>
static bool valueCompare(It it, const_iterator it2) { return *it != *it2; }
};
} }
template<typename Range> template<typename Range>