kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cmCTestTestHandler: take reference to temporary string instead of doing a copy 

This will increase the lifetime of the temporary until the end of the function.
This commit is contained in:
Rolf Eike Beer 2014-12-22 21:38:59 +01:00
parent 6697765230
commit 82fbf490b5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Source/CTest/cmCTestTestHandler.cxx
View File

@ -1317,7 +1317,7 @@ void cmCTestTestHandler::AttachFiles(std::ostream& os,
result->Properties->AttachedFiles.begin(); result->Properties->AttachedFiles.begin();
file != result->Properties->AttachedFiles.end(); ++file) file != result->Properties->AttachedFiles.end(); ++file)
{ {
std::string base64 = this->CTest->Base64GzipEncodeFile(*file); const std::string &base64 = this->CTest->Base64GzipEncodeFile(*file);
std::string fname = cmSystemTools::GetFilenameName(*file); std::string fname = cmSystemTools::GetFilenameName(*file);
os << "\t\t<NamedMeasurement name=\"Attached File\" encoding=\"base64\" " os << "\t\t<NamedMeasurement name=\"Attached File\" encoding=\"base64\" "
"compression=\"tar/gzip\" filename=\"" << fname << "\" type=\"file\">" "compression=\"tar/gzip\" filename=\"" << fname << "\" type=\"file\">"