kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

BUG: Avoid encoding invalid XML chars in CTest 

CTest encodes test and tool output in XML for dashboard submission.
This fixes the XML encoding implementation to not encode an invalid
character and instead put a human-readable tag in its place.
See issue #8647.
This commit is contained in:
Brad King 2009-03-02 16:27:50 -05:00
parent ed5e4d8be2
commit 82e9291629
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Source/cmXMLSafe.cxx
View File

@ -82,7 +82,17 @@ cmsys_ios::ostream& operator<<(cmsys_ios::ostream& os, cmXMLSafe const& self)
// encoding. Instead of escaping these bytes, we should
// handle the current locale and its encoding.
char buf[16];
sprintf(buf, "[bad-char-%hx]", static_cast<unsigned short>(c));
// http://www.w3.org/TR/REC-xml/#NT-Char
if(c >= 0x80)
{
sprintf(buf, "&#x%hx;", static_cast<unsigned short>(c));
}
else
{
// We cannot use "&#x%hx;" here because this value is not
// valid in XML. Instead use a human-readable hex value.
sprintf(buf, "&lt;0x%hx&gt;", static_cast<unsigned short>(c));
}
os << buf;
}
break;