diff --git a/Source/cmGetCMakePropertyCommand.cxx b/Source/cmGetCMakePropertyCommand.cxx index e193cf5b0..c0e4683a2 100644 --- a/Source/cmGetCMakePropertyCommand.cxx +++ b/Source/cmGetCMakePropertyCommand.cxx @@ -25,7 +25,6 @@ bool cmGetCMakePropertyCommand return false; } - std::vector::size_type cc; std::string variable = args[0]; std::string output = "NOTFOUND"; @@ -35,12 +34,15 @@ bool cmGetCMakePropertyCommand std::vector vars = this->Makefile->GetDefinitions(cacheonly); if (!vars.empty()) { - output = vars[0]; - } - for ( cc = 1; cc < vars.size(); ++cc ) - { - output += ";"; - output += vars[cc]; + output = ""; + const char* sep = ""; + std::vector::size_type cc; + for ( cc = 0; cc < vars.size(); ++cc ) + { + output += sep; + output += vars[cc]; + sep = ";"; + } } } else if ( args[1] == "MACROS" ) @@ -54,13 +56,12 @@ bool cmGetCMakePropertyCommand ->GetInstallComponents(); std::set::const_iterator compIt; output = ""; + const char* sep = ""; for (compIt = components->begin(); compIt != components->end(); ++compIt) { - if (compIt != components->begin()) - { - output += ";"; - } + output += sep; output += *compIt; + sep = ";"; } } else diff --git a/Source/cmMakefile.cxx b/Source/cmMakefile.cxx index eb68e4986..aca4413a2 100644 --- a/Source/cmMakefile.cxx +++ b/Source/cmMakefile.cxx @@ -3752,15 +3752,12 @@ void cmMakefile::GetListOfMacros(std::string& macros) const { StringStringMap::const_iterator it; macros = ""; - int cc = 0; + const char* sep = ""; for ( it = this->MacrosMap.begin(); it != this->MacrosMap.end(); ++it ) { - if ( cc > 0 ) - { - macros += ";"; - } + macros += sep; macros += it->first; - cc ++; + sep = ""; } } @@ -4205,15 +4202,14 @@ const char *cmMakefile::GetProperty(const std::string& prop, } else if (prop == "LISTFILE_STACK") { + const char* sep = ""; for (std::deque::const_iterator i = this->ListFileStack.begin(); i != this->ListFileStack.end(); ++i) { - if (i != this->ListFileStack.begin()) - { - output += ";"; - } + output += sep; output += *i; + sep = ";"; } return output.c_str(); } @@ -4225,13 +4221,12 @@ const char *cmMakefile::GetProperty(const std::string& prop, cacheonly = 1; } std::vector vars = this->GetDefinitions(cacheonly); + const char* sep = ""; for (unsigned int cc = 0; cc < vars.size(); cc ++ ) { - if ( cc > 0 ) - { - output += ";"; - } + output += sep; output += vars[cc]; + sep = ";"; } return output.c_str(); } @@ -4247,19 +4242,16 @@ const char *cmMakefile::GetProperty(const std::string& prop, } else if (prop == "LINK_DIRECTORIES") { - std::ostringstream str; + const char* sep = ""; for (std::vector::const_iterator it = this->GetLinkDirectories().begin(); it != this->GetLinkDirectories().end(); ++ it ) { - if ( it != this->GetLinkDirectories().begin()) - { - str << ";"; - } - str << it->c_str(); + output += sep; + output += *it; + sep = ";"; } - output = str.str(); return output.c_str(); } else if (prop == "INCLUDE_DIRECTORIES")