kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cmExportInstallFileGenerator: Fix crash in FindNamespaces 

Refactoring merged by commit 9afbb733ec (Merge topic
'use-generator-target', 2015-10-20) in and around commit 381e7afd
(cmExportSet: Store a cmGeneratorTarget, 2015-10-17) forgot to update
one place in this method.  This leads to a crash in code such as

  add_library(A a.c)
  add_library(B b.c)
  target_link_libraries(B A)
  install(TARGETS B DESTINATION lib EXPORT ExpB)
  install(EXPORT ExpB DESTINATION lib/cmake/test)
  add_executable(C c.c)
  install(TARGETS C DESTINATION bin EXPORT ExpC)

Fix the target name reference to avoid using an unpopulated Target
pointer.
This commit is contained in:
Andrey Pokrovskiy 2016-01-20 18:29:58 -08:00 committed by Brad King
parent 750ae8d5a8
commit 7dbfdddf33
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Source/cmExportInstallFileGenerator.cxx
View File

@ -496,7 +496,7 @@ cmExportInstallFileGenerator
bool containsTarget = false; bool containsTarget = false;
for(unsigned int i=0; i<targets->size(); i++) for(unsigned int i=0; i<targets->size(); i++)
{ {
if (name == (*targets)[i]->Target->GetName()) if (name == (*targets)[i]->TargetName)
{ {
containsTarget = true; containsTarget = true;
break; break;