From 789a0f83594cd3bafcc9a3051a5ed53ec76c8684 Mon Sep 17 00:00:00 2001 From: Brad King Date: Thu, 8 Mar 2007 15:24:01 -0500 Subject: [PATCH] ENH: Removed unused variables LibraryOutputPath and ExecutableOutputPath. Each target is asked for its own output directory. This is a step towards bug#2240. --- Source/cmGlobalXCodeGenerator.cxx | 44 ------------------------------- Source/cmGlobalXCodeGenerator.h | 3 --- 2 files changed, 47 deletions(-) diff --git a/Source/cmGlobalXCodeGenerator.cxx b/Source/cmGlobalXCodeGenerator.cxx index fdcc12f3a..77715fb3f 100644 --- a/Source/cmGlobalXCodeGenerator.cxx +++ b/Source/cmGlobalXCodeGenerator.cxx @@ -211,49 +211,6 @@ std::string cmGlobalXCodeGenerator return makeCommand; } -//---------------------------------------------------------------------------- -void cmGlobalXCodeGenerator::ConfigureOutputPaths() -{ - // Format the library and executable output paths. - this->LibraryOutputPath = - this->CurrentMakefile->GetSafeDefinition("LIBRARY_OUTPUT_PATH"); - if(this->LibraryOutputPath.size() == 0) - { - this->LibraryOutputPath = - this->CurrentMakefile->GetCurrentOutputDirectory(); - } - // make sure there is a trailing slash - if(this->LibraryOutputPath.size() && - this->LibraryOutputPath[this->LibraryOutputPath.size()-1] != '/') - { - this->LibraryOutputPath += "/"; - if(!cmSystemTools::MakeDirectory(this->LibraryOutputPath.c_str())) - { - cmSystemTools::Error("Error creating directory ", - this->LibraryOutputPath.c_str()); - } - } - this->CurrentMakefile->AddLinkDirectory(this->LibraryOutputPath.c_str()); - this->ExecutableOutputPath = - this->CurrentMakefile->GetSafeDefinition("EXECUTABLE_OUTPUT_PATH"); - if(this->ExecutableOutputPath.size() == 0) - { - this->ExecutableOutputPath = - this->CurrentMakefile->GetCurrentOutputDirectory(); - } - // make sure there is a trailing slash - if(this->ExecutableOutputPath.size() && - this->ExecutableOutputPath[this->ExecutableOutputPath.size()-1] != '/') - { - this->ExecutableOutputPath += "/"; - if(!cmSystemTools::MakeDirectory(this->ExecutableOutputPath.c_str())) - { - cmSystemTools::Error("Error creating directory ", - this->ExecutableOutputPath.c_str()); - } - } -} - //---------------------------------------------------------------------------- ///! Create a local generator appropriate to this Global Generator cmLocalGenerator *cmGlobalXCodeGenerator::CreateLocalGenerator() @@ -1108,7 +1065,6 @@ void cmGlobalXCodeGenerator::CreateBuildSettings(cmTarget& target, std::string& productName, const char* configName) { - this->ConfigureOutputPaths(); std::string flags; std::string defFlags; bool shared = ((target.GetType() == cmTarget::SHARED_LIBRARY) || diff --git a/Source/cmGlobalXCodeGenerator.h b/Source/cmGlobalXCodeGenerator.h index 27470d62a..e9091e42d 100644 --- a/Source/cmGlobalXCodeGenerator.h +++ b/Source/cmGlobalXCodeGenerator.h @@ -146,7 +146,6 @@ private: std::vector&); void AddDependTarget(cmXCodeObject* target, cmXCodeObject* dependTarget); - void ConfigureOutputPaths(); void CreateXCodeDependHackTarget(std::vector& targets); bool SpecialTargetEmitted(std::string const& tname); void AddExtraTargets(cmLocalGenerator* root, @@ -179,8 +178,6 @@ private: std::string CurrentXCodeHackMakefile; std::string CurrentProject; std::string OutputDir; - std::string LibraryOutputPath; - std::string ExecutableOutputPath; std::set TargetDoneSet; std::vector CurrentOutputDirectoryComponents; std::vector ProjectOutputDirectoryComponents;