cmListFileArgument: Remove FilePath member.

It is now unused.
This commit is contained in:
Stephen Kelly 2015-05-23 23:43:37 +02:00
parent a863c59f70
commit 782657db48
6 changed files with 14 additions and 34 deletions

View File

@ -426,8 +426,7 @@ int CCONV cmExecuteCommand(void *arg, const char *name,
{ {
// Assume all arguments are quoted. // Assume all arguments are quoted.
lff.Arguments.push_back( lff.Arguments.push_back(
cmListFileArgument(args[i], cmListFileArgument::Quoted, cmListFileArgument(args[i], cmListFileArgument::Quoted, 0));
"[CMake-Plugin]", 0));
} }
cmExecutionStatus status; cmExecutionStatus status;
return mf->ExecuteCommand(lff,status); return mf->ExecuteCommand(lff,status);

View File

@ -176,17 +176,6 @@ IsFunctionBlocked(const cmListFileFunction& lff, cmMakefile &mf,
f->FilePath = this->GetStartingContext().FilePath; f->FilePath = this->GetStartingContext().FilePath;
mf.RecordPolicies(f->Policies); mf.RecordPolicies(f->Policies);
// Set the FilePath on the arguments to match the function since it is
// not stored and the original values may be freed
for (unsigned int i = 0; i < f->Functions.size(); ++i)
{
for (unsigned int j = 0; j < f->Functions[i].Arguments.size(); ++j)
{
f->Functions[i].Arguments[j].FilePath =
f->Functions[i].FilePath.c_str();
}
}
std::string newName = "_" + this->Args[0]; std::string newName = "_" + this->Args[0];
mf.GetState()->RenameCommand(this->Args[0], newName); mf.GetState()->RenameCommand(this->Args[0], newName);
mf.GetState()->AddCommand(f); mf.GetState()->AddCommand(f);

View File

@ -234,8 +234,7 @@ bool cmListFile::ParseFile(const char* filename,
{ {
cmListFileFunction project; cmListFileFunction project;
project.Name = "PROJECT"; project.Name = "PROJECT";
cmListFileArgument prj("Project", cmListFileArgument::Unquoted, cmListFileArgument prj("Project", cmListFileArgument::Unquoted, 0);
filename, 0);
project.Arguments.push_back(prj); project.Arguments.push_back(prj);
this->Functions.insert(this->Functions.begin(),project); this->Functions.insert(this->Functions.begin(),project);
} }
@ -375,7 +374,7 @@ bool cmListFileParser::ParseFunction(const char* name, long line)
bool cmListFileParser::AddArgument(cmListFileLexer_Token* token, bool cmListFileParser::AddArgument(cmListFileLexer_Token* token,
cmListFileArgument::Delimiter delim) cmListFileArgument::Delimiter delim)
{ {
cmListFileArgument a(token->text, delim, this->FileName, token->line); cmListFileArgument a(token->text, delim, token->line);
this->Function.Arguments.push_back(a); this->Function.Arguments.push_back(a);
if(this->Separation == SeparationOkay) if(this->Separation == SeparationOkay)
{ {

View File

@ -33,12 +33,11 @@ struct cmListFileArgument
Quoted, Quoted,
Bracket Bracket
}; };
cmListFileArgument(): Value(), Delim(Unquoted), FilePath(0), Line(0) {} cmListFileArgument(): Value(), Delim(Unquoted), Line(0) {}
cmListFileArgument(const cmListFileArgument& r): cmListFileArgument(const cmListFileArgument& r)
Value(r.Value), Delim(r.Delim), FilePath(r.FilePath), Line(r.Line) {} : Value(r.Value), Delim(r.Delim), Line(r.Line) {}
cmListFileArgument(const std::string& v, Delimiter d, const char* file, cmListFileArgument(const std::string& v, Delimiter d, long line)
long line): Value(v), Delim(d), : Value(v), Delim(d), Line(line) {}
FilePath(file), Line(line) {}
bool operator == (const cmListFileArgument& r) const bool operator == (const cmListFileArgument& r) const
{ {
return (this->Value == r.Value) && (this->Delim == r.Delim); return (this->Value == r.Value) && (this->Delim == r.Delim);
@ -49,7 +48,6 @@ struct cmListFileArgument
} }
std::string Value; std::string Value;
Delimiter Delim; Delimiter Delim;
const char* FilePath;
long Line; long Line;
}; };

View File

@ -139,10 +139,6 @@ bool cmMacroHelperCommand::InvokeInitialPass
this->Functions[c].Arguments.begin(); this->Functions[c].Arguments.begin();
k != this->Functions[c].Arguments.end(); ++k) k != this->Functions[c].Arguments.end(); ++k)
{ {
// Set the FilePath on the arguments to match the function since it is
// not stored and the original values may be freed
k->FilePath = this->FilePath.c_str();
cmListFileArgument arg; cmListFileArgument arg;
arg.Value = k->Value; arg.Value = k->Value;
if(k->Delim != cmListFileArgument::Bracket) if(k->Delim != cmListFileArgument::Bracket)
@ -173,7 +169,6 @@ bool cmMacroHelperCommand::InvokeInitialPass
} }
} }
arg.Delim = k->Delim; arg.Delim = k->Delim;
arg.FilePath = k->FilePath;
arg.Line = k->Line; arg.Line = k->Line;
newLFF.Arguments.push_back(arg); newLFF.Arguments.push_back(arg);
} }

View File

@ -49,21 +49,21 @@ static void cmVariableWatchCommandVariableAccessed(
newLFF.Arguments.clear(); newLFF.Arguments.clear();
newLFF.Arguments.push_back( newLFF.Arguments.push_back(
cmListFileArgument(variable, cmListFileArgument::Quoted, cmListFileArgument(variable, cmListFileArgument::Quoted,
"unknown", 9999)); 9999));
newLFF.Arguments.push_back( newLFF.Arguments.push_back(
cmListFileArgument(accessString, cmListFileArgument::Quoted, cmListFileArgument(accessString, cmListFileArgument::Quoted,
"unknown", 9999)); 9999));
newLFF.Arguments.push_back( newLFF.Arguments.push_back(
cmListFileArgument(newValue?newValue:"", cmListFileArgument::Quoted, cmListFileArgument(newValue?newValue:"", cmListFileArgument::Quoted,
"unknown", 9999)); 9999));
newLFF.Arguments.push_back( newLFF.Arguments.push_back(
cmListFileArgument(currentListFile, cmListFileArgument::Quoted, cmListFileArgument(currentListFile, cmListFileArgument::Quoted,
"unknown", 9999)); 9999));
newLFF.Arguments.push_back( newLFF.Arguments.push_back(
cmListFileArgument(stack, cmListFileArgument::Quoted, cmListFileArgument(stack, cmListFileArgument::Quoted,
"unknown", 9999)); 9999));
newLFF.Name = data->Command; newLFF.Name = data->Command;
newLFF.FilePath = "Some weird path"; newLFF.FilePath = "unknown";
newLFF.Line = 9999; newLFF.Line = 9999;
cmExecutionStatus status; cmExecutionStatus status;
if(!makefile->ExecuteCommand(newLFF,status)) if(!makefile->ExecuteCommand(newLFF,status))