From 6b5614f1642dcb75fd9de9571c813b21e4f9ce2b Mon Sep 17 00:00:00 2001 From: Peter Collingbourne Date: Mon, 26 Mar 2012 04:16:15 +0100 Subject: [PATCH] Ninja: Substitute and in depfile flags Patch by Amine Khaldi! Also, start using the -MT flag to set a target name for depfiles. This works around a bug observed in distcc, as explained in the comment. Based on a patch by Alexander Usov. --- Modules/Compiler/GNU.cmake | 5 ++++- Source/cmNinjaTargetGenerator.cxx | 4 ++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/Modules/Compiler/GNU.cmake b/Modules/Compiler/GNU.cmake index bdcaf9d62..c74c17919 100644 --- a/Modules/Compiler/GNU.cmake +++ b/Modules/Compiler/GNU.cmake @@ -30,7 +30,10 @@ macro(__compiler_gnu lang) # in try_compile mode. GET_PROPERTY(_IN_TC GLOBAL PROPERTY IN_TRY_COMPILE) if(NOT _IN_TC OR CMAKE_FORCE_DEPFILES) - set(CMAKE_DEPFILE_FLAGS_${lang} "-MMD -MF ") + # distcc does not transform -o to -MT when invoking the preprocessor + # internally, as it ought to. Work around this bug by setting -MT here + # even though it isn't strictly necessary. + set(CMAKE_DEPFILE_FLAGS_${lang} "-MMD -MT -MF ") endif() # Initial configuration flags. diff --git a/Source/cmNinjaTargetGenerator.cxx b/Source/cmNinjaTargetGenerator.cxx index 9acbc676a..bea234f47 100644 --- a/Source/cmNinjaTargetGenerator.cxx +++ b/Source/cmNinjaTargetGenerator.cxx @@ -331,6 +331,10 @@ cmNinjaTargetGenerator depfile = "$out.d"; cmSystemTools::ReplaceString(depfileFlagsStr, "", depfile.c_str()); + cmSystemTools::ReplaceString(depfileFlagsStr, "", + "$out"); + cmSystemTools::ReplaceString(depfileFlagsStr, "", + this->GetMakefile()->GetDefinition("CMAKE_C_COMPILER")); flags += " " + depfileFlagsStr; } vars.Flags = flags.c_str();