kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge branch 'fix-cache-self-assignment' into release

This commit is contained in:
Brad King 2014-05-27 16:21:37 -04:00
parent a8c6b309b1 1cd3752729
commit 61a1612a17
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Source/cmCacheManager.cxx
View File

@ -750,11 +750,7 @@ void cmCacheManager::AddCacheEntry(const char* key,
} }
e.SetProperty("HELPSTRING", helpString? helpString : e.SetProperty("HELPSTRING", helpString? helpString :
"(This variable does not exist and should not be used)"); "(This variable does not exist and should not be used)");
if (this->Cache[key].Value == e.Value) this->CMakeInstance->UnwatchUnusedCli(key);
{
this->CMakeInstance->UnwatchUnusedCli(key);
}
this->Cache[key] = e;
} }
bool cmCacheManager::CacheIterator::IsAtEnd() const bool cmCacheManager::CacheIterator::IsAtEnd() const

5
Source/cmake.cxx
View File

@ -1231,7 +1231,10 @@ int cmake::HandleDeleteCacheVariables(const char* var)
if(ci.Find(save.key.c_str())) if(ci.Find(save.key.c_str()))
{ {
save.type = ci.GetType(); save.type = ci.GetType();
save.help = ci.GetProperty("HELPSTRING"); if(const char* help = ci.GetProperty("HELPSTRING"))
{
save.help = help;
}
} }
saved.push_back(save); saved.push_back(save);
} }