kolan/CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

BUG: Do not close handle obtained from GetModuleHandle which does not increase the reference count of the module.

Browse Source
This commit is contained in:
Brad King 2005-11-16 11:36:05 -05:00
parent 1d4b3f8388
commit 5dae3d67f4
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Source/kwsys/ProcessWin32.c
View File

@ -2487,6 +2487,10 @@ static int kwsysProcess_List_NextProcess(kwsysProcess_List* self)
/*--------------------------------------------------------------------------*/ /*--------------------------------------------------------------------------*/
static int kwsysProcess_List__New_NT4(kwsysProcess_List* self) static int kwsysProcess_List__New_NT4(kwsysProcess_List* self)
{ {
/* Get a handle to the NT runtime module that should already be
loaded in this program. This does not actually increment the
reference count to the module so we do not need to close the
handle. */
HANDLE hNT = GetModuleHandle("ntdll.dll"); HANDLE hNT = GetModuleHandle("ntdll.dll");
if(hNT) if(hNT)
{ {
@ -2494,7 +2498,6 @@ static int kwsysProcess_List__New_NT4(kwsysProcess_List* self)
self->P_ZwQuerySystemInformation = self->P_ZwQuerySystemInformation =
((ZwQuerySystemInformationType) ((ZwQuerySystemInformationType)
GetProcAddress(hNT, "ZwQuerySystemInformation")); GetProcAddress(hNT, "ZwQuerySystemInformation"));
CloseHandle(hNT);
} }
if(!self->P_ZwQuerySystemInformation) if(!self->P_ZwQuerySystemInformation)
{ {
@ -2588,6 +2591,10 @@ static int kwsysProcess_List__GetParentId_NT4(kwsysProcess_List* self)
/*--------------------------------------------------------------------------*/ /*--------------------------------------------------------------------------*/
static int kwsysProcess_List__New_Snapshot(kwsysProcess_List* self) static int kwsysProcess_List__New_Snapshot(kwsysProcess_List* self)
{ {
/* Get a handle to the Windows runtime module that should already be
loaded in this program. This does not actually increment the
reference count to the module so we do not need to close the
handle. */
HANDLE hKernel = GetModuleHandle("kernel32.dll"); HANDLE hKernel = GetModuleHandle("kernel32.dll");
if(hKernel) if(hKernel)
{ {
@ -2600,7 +2607,6 @@ static int kwsysProcess_List__New_Snapshot(kwsysProcess_List* self)
self->P_Process32Next = self->P_Process32Next =
((Process32NextType) ((Process32NextType)
GetProcAddress(hKernel, "Process32Next")); GetProcAddress(hKernel, "Process32Next"));
CloseHandle(hKernel);
} }
return (self->P_CreateToolhelp32Snapshot && return (self->P_CreateToolhelp32Snapshot &&
self->P_Process32First && self->P_Process32First &&