kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

export: Error when exporting a target without a language 

First, it prevents a NULL dereference and second it reiterates that
targets without languages are not supported by CMake.

Add a RunCMake.ExportWithoutLanguage test exporting a library without a
languages.
This commit is contained in:
Ben Boeckel 2013-07-22 17:25:21 -04:00 committed by Brad King
parent 2f8dace125
commit 5837f19690
7 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Source/cmExportFileGenerator.cxx
View File

@ -349,6 +349,16 @@ void getCompatibleInterfaceProperties(cmTarget *target,
{ {
cmComputeLinkInformation *info = target->GetLinkInformation(config); cmComputeLinkInformation *info = target->GetLinkInformation(config);
if (!info)
{
cmMakefile* mf = target->GetMakefile();
cmOStringStream e;
e << "Exporting the target \"" << target->GetName() << "\" is not "
"allowed since its linker language cannot be determined";
mf->IssueMessage(cmake::FATAL_ERROR, e.str());
return;
}
const cmComputeLinkInformation::ItemVector &deps = info->GetItems(); const cmComputeLinkInformation::ItemVector &deps = info->GetItems();
for(cmComputeLinkInformation::ItemVector::const_iterator li = for(cmComputeLinkInformation::ItemVector::const_iterator li =

1
Tests/RunCMake/CMakeLists.txt
View File

@ -115,4 +115,5 @@ if("${CMAKE_TEST_GENERATOR}" MATCHES "Visual Studio [^6]")
endif() endif()
add_RunCMake_test(File_Generate) add_RunCMake_test(File_Generate)
add_RunCMake_test(ExportWithoutLanguage)
add_RunCMake_test(target_link_libraries) add_RunCMake_test(target_link_libraries)

3
Tests/RunCMake/ExportWithoutLanguage/CMakeLists.txt Normal file
View File

@ -0,0 +1,3 @@
cmake_minimum_required(VERSION 2.8)
project(${RunCMake_TEST} NONE)
include(${RunCMake_TEST}.cmake)

1
Tests/RunCMake/ExportWithoutLanguage/NoLanguage-result.txt Normal file
View File

@ -0,0 +1 @@
1

6
Tests/RunCMake/ExportWithoutLanguage/NoLanguage-stderr.txt Normal file
View File

@ -0,0 +1,6 @@
CMake Error: CMake can not determine linker language for target: NoLanguage
CMake Error at NoLanguage.cmake:2 \(export\):
Exporting the target "NoLanguage" is not allowed since its linker language
cannot be determined
Call Stack \(most recent call first\):
CMakeLists.txt:3 \(include\)

2
Tests/RunCMake/ExportWithoutLanguage/NoLanguage.cmake Normal file
View File

@ -0,0 +1,2 @@
add_library(NoLanguage header.h)
export(TARGETS NoLanguage FILE "${CMAKE_CURRENT_BINARY_DIR}/export.cmake")

3
Tests/RunCMake/ExportWithoutLanguage/RunCMakeTest.cmake Normal file
View File

@ -0,0 +1,3 @@
include(RunCMake)
run_cmake(NoLanguage)