kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

docbook: Fix formatter naming convention to avoid shadow 

Some compilers complain:

 cmDocumentationFormatterDocbook.cxx: In member function virtual void cmDocumentationFormatterDocbook::PrintHeader(const char*, const char*, std::ostream&):
 cmDocumentationFormatterDocbook.cxx:197:73: warning: declaration of docname shadows a member of 'this' [-Wshadow]

Fix the name of the member variable.
This commit is contained in:
Brad King 2012-09-09 10:55:22 -04:00
parent 9ad85dbb25
commit 4e62784bf6
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Source/cmDocumentationFormatterDocbook.cxx
View File

@ -196,7 +196,7 @@ void cmDocumentationFormatterDocbook
void cmDocumentationFormatterDocbook void cmDocumentationFormatterDocbook
::PrintHeader(const char* docname, const char* appname, std::ostream& os) ::PrintHeader(const char* docname, const char* appname, std::ostream& os)
{ {
this->docname = docname; this->Docname = docname;
// this one is used to ensure that we don't create multiple link targets // this one is used to ensure that we don't create multiple link targets
// with the same name. We can clear it here since we are at the // with the same name. We can clear it here since we are at the
@ -229,7 +229,7 @@ void cmDocumentationFormatterDocbook
{ {
id = std::string(prefix) + "." + id; id = std::string(prefix) + "." + id;
} }
os << this->docname << '.' << id; os << this->Docname << '.' << id;
// make sure that each id exists only once. Since it seems // make sure that each id exists only once. Since it seems
// not easily possible to determine which link refers to which id, // not easily possible to determine which link refers to which id,

2
Source/cmDocumentationFormatterDocbook.h
View File

@ -37,7 +37,7 @@ public:
private: private:
void PrintId(std::ostream& os, const char* prefix, std::string id); void PrintId(std::ostream& os, const char* prefix, std::string id);
std::set<std::string> EmittedLinkIds; std::set<std::string> EmittedLinkIds;
std::string docname; std::string Docname;
}; };
#endif #endif