From 165f6430d957173a0c3fda48265d8ed761700e20 Mon Sep 17 00:00:00 2001 From: Bas Couwenberg Date: Fri, 28 Feb 2014 14:12:18 +0100 Subject: [PATCH 1/3] FindRuby: Add support for Ruby 2.0 and 2.1 The most significant change since Ruby 1.9 is the changed path of config.h, from RbConfig::CONFIG['rubyhdrdir'] to RbConfig::CONFIG['rubyarchhdrdir']. --- Modules/FindRuby.cmake | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/Modules/FindRuby.cmake b/Modules/FindRuby.cmake index 9d9383d2a..aafdc09cf 100644 --- a/Modules/FindRuby.cmake +++ b/Modules/FindRuby.cmake @@ -5,7 +5,8 @@ # Find Ruby # # This module finds if Ruby is installed and determines where the -# include files and libraries are. Ruby 1.8 and 1.9 are supported. +# include files and libraries are. Ruby 1.8, 1.9, 2.0 and 2.1 are +# supported. # # The minimum required version of Ruby can be specified using the # standard syntax, e.g. find_package(Ruby 1.8) @@ -67,6 +68,8 @@ else() endif() if(NOT Ruby_FIND_VERSION_EXACT) + list(APPEND _RUBY_POSSIBLE_EXECUTABLE_NAMES ruby2.1 ruby21) + list(APPEND _RUBY_POSSIBLE_EXECUTABLE_NAMES ruby2.0 ruby20) list(APPEND _RUBY_POSSIBLE_EXECUTABLE_NAMES ruby1.9 ruby19) # if we want a version below 1.9, also look for ruby 1.8 @@ -79,7 +82,6 @@ endif() find_program(RUBY_EXECUTABLE NAMES ${_RUBY_POSSIBLE_EXECUTABLE_NAMES}) - if(RUBY_EXECUTABLE AND NOT RUBY_VERSION_MAJOR) function(_RUBY_CONFIG_VAR RBVAR OUTVAR) execute_process(COMMAND ${RUBY_EXECUTABLE} -r rbconfig -e "print RbConfig::CONFIG['${RBVAR}']" @@ -105,6 +107,7 @@ if(RUBY_EXECUTABLE AND NOT RUBY_VERSION_MAJOR) _RUBY_CONFIG_VAR("archdir" RUBY_ARCH_DIR) _RUBY_CONFIG_VAR("arch" RUBY_ARCH) _RUBY_CONFIG_VAR("rubyhdrdir" RUBY_HDR_DIR) + _RUBY_CONFIG_VAR("rubyarchhdrdir" RUBY_ARCHHDR_DIR) _RUBY_CONFIG_VAR("libdir" RUBY_POSSIBLE_LIB_DIR) _RUBY_CONFIG_VAR("rubylibdir" RUBY_RUBY_LIB_DIR) @@ -126,7 +129,8 @@ if(RUBY_EXECUTABLE AND NOT RUBY_VERSION_MAJOR) set(RUBY_VERSION_MINOR ${RUBY_VERSION_MINOR} CACHE PATH "The Ruby minor version" FORCE) set(RUBY_VERSION_PATCH ${RUBY_VERSION_PATCH} CACHE PATH "The Ruby patch version" FORCE) set(RUBY_ARCH_DIR ${RUBY_ARCH_DIR} CACHE PATH "The Ruby arch dir" FORCE) - set(RUBY_HDR_DIR ${RUBY_HDR_DIR} CACHE PATH "The Ruby header dir (1.9)" FORCE) + set(RUBY_HDR_DIR ${RUBY_HDR_DIR} CACHE PATH "The Ruby header dir (1.9+)" FORCE) + set(RUBY_ARCHHDR_DIR ${RUBY_ARCHHDR_DIR} CACHE PATH "The Ruby arch header dir (2.0+)" FORCE) set(RUBY_POSSIBLE_LIB_DIR ${RUBY_POSSIBLE_LIB_DIR} CACHE PATH "The Ruby lib dir" FORCE) set(RUBY_RUBY_LIB_DIR ${RUBY_RUBY_LIB_DIR} CACHE PATH "The Ruby ruby-lib dir" FORCE) set(RUBY_SITEARCH_DIR ${RUBY_SITEARCH_DIR} CACHE PATH "The Ruby site arch dir" FORCE) @@ -139,6 +143,7 @@ if(RUBY_EXECUTABLE AND NOT RUBY_VERSION_MAJOR) RUBY_ARCH_DIR RUBY_ARCH RUBY_HDR_DIR + RUBY_ARCHHDR_DIR RUBY_POSSIBLE_LIB_DIR RUBY_RUBY_LIB_DIR RUBY_SITEARCH_DIR @@ -160,10 +165,20 @@ if(RUBY_EXECUTABLE AND NOT RUBY_VERSION_MAJOR) set(RUBY_VERSION_MINOR 8) set(RUBY_VERSION_PATCH 0) # check whether we found 1.9.x - if(${RUBY_EXECUTABLE} MATCHES "ruby1.?9" OR RUBY_HDR_DIR) + if(${RUBY_EXECUTABLE} MATCHES "ruby1.?9") set(RUBY_VERSION_MAJOR 1) set(RUBY_VERSION_MINOR 9) endif() + # check whether we found 2.0.x + if(${RUBY_EXECUTABLE} MATCHES "ruby2.?0") + set(RUBY_VERSION_MAJOR 2) + set(RUBY_VERSION_MINOR 0) + endif() + # check whether we found 2.1.x + if(${RUBY_EXECUTABLE} MATCHES "ruby2.?1") + set(RUBY_VERSION_MAJOR 2) + set(RUBY_VERSION_MINOR 1) + endif() endif() if(RUBY_VERSION_MAJOR) @@ -189,6 +204,7 @@ if( "${Ruby_FIND_VERSION_SHORT_NODOT}" GREATER 18 OR "${_RUBY_VERSION_SHORT_NO HINTS ${RUBY_HDR_DIR}/${RUBY_ARCH} ${RUBY_ARCH_DIR} + ${RUBY_ARCHHDR_DIR} ) set(RUBY_INCLUDE_DIRS ${RUBY_INCLUDE_DIRS} ${RUBY_CONFIG_INCLUDE_DIR} ) From 57abfeaac55bd1b94c8e1f9f4d06f90910d86aa8 Mon Sep 17 00:00:00 2001 From: Brad King Date: Fri, 28 Feb 2014 08:47:12 -0500 Subject: [PATCH 2/3] Help: Add FindRuby-2 topic release notes --- Help/release/dev/FindRuby-2.rst | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 Help/release/dev/FindRuby-2.rst diff --git a/Help/release/dev/FindRuby-2.rst b/Help/release/dev/FindRuby-2.rst new file mode 100644 index 000000000..50d9a4866 --- /dev/null +++ b/Help/release/dev/FindRuby-2.rst @@ -0,0 +1,4 @@ +FindRuby-2 +---------- + +* The :module:`FindRuby` module learned to search for Ruby 2.0 and 2.1. From 5161f7bc3662b5d14ea6454166441611fbecd3e9 Mon Sep 17 00:00:00 2001 From: Brad King Date: Fri, 28 Feb 2014 08:50:05 -0500 Subject: [PATCH 3/3] Help: Consolidate FindRuby-2 release notes for 3.0.0 --- Help/release/3.0.0.rst | 2 ++ Help/release/dev/FindRuby-2.rst | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) delete mode 100644 Help/release/dev/FindRuby-2.rst diff --git a/Help/release/3.0.0.rst b/Help/release/3.0.0.rst index 105d6519d..dd43180c5 100644 --- a/Help/release/3.0.0.rst +++ b/Help/release/3.0.0.rst @@ -241,6 +241,8 @@ Modules for Qt executables. This helps disambiguate when using multiple :manual:`Qt versions ` in the same buildsystem. +* The :module:`FindRuby` module learned to search for Ruby 2.0 and 2.1. + Generator Expressions --------------------- diff --git a/Help/release/dev/FindRuby-2.rst b/Help/release/dev/FindRuby-2.rst deleted file mode 100644 index 50d9a4866..000000000 --- a/Help/release/dev/FindRuby-2.rst +++ /dev/null @@ -1,4 +0,0 @@ -FindRuby-2 ----------- - -* The :module:`FindRuby` module learned to search for Ruby 2.0 and 2.1.