kolan/CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cmDefinitions: Avoid a find-then-insert when setting variables

Browse Source 
Searching the map is not necessary.
This commit is contained in:
Ben Boeckel 2014-03-12 14:03:41 -04:00
parent 5abfde6cb8
commit 3b21705d53
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Source/cmDefinitions.cxx
View File

@ -50,16 +50,7 @@ cmDefinitions::SetInternal(const std::string& key, Def const& def)
if(this->Up || def.Exists) if(this->Up || def.Exists)
{ {
// In lower scopes we store keys, defined or not. // In lower scopes we store keys, defined or not.
MapType::iterator i = this->Map.find(key); return (this->Map[key] = def);
if(i == this->Map.end())
{
i = this->Map.insert(MapType::value_type(key, def)).first;
}
else
{
i->second = def;
}
return i->second;
} }
else else
{ {