kolan
/
CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cmPolicies: Trivialize GetPolicyStatus method. 

It would be possible to implement this with an XMacro and switch
statement, but every codepath currently would still return WARN.
This commit is contained in:
Stephen Kelly 2015-05-03 10:10:38 +02:00
parent dbf680d670
commit 387aff200c
1 changed files with 5 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
Source/cmPolicies.cxx
View File

@ -124,15 +124,12 @@ const char* idToShortDescription(cmPolicies::PolicyID id)
class cmPolicy class cmPolicy
{ {
public: public:
cmPolicy(cmPolicies::PolicyID iD, cmPolicy(cmPolicies::PolicyID iD)
cmPolicies::PolicyStatus status)
{ {
this->ID = iD; this->ID = iD;
this->Status = status;
} }
cmPolicies::PolicyID ID; cmPolicies::PolicyID ID;
cmPolicies::PolicyStatus Status;
}; };
cmPolicies::cmPolicies() cmPolicies::cmPolicies()
@ -460,10 +457,9 @@ void cmPolicies::DefinePolicy(cmPolicies::PolicyID iD,
unsigned int, unsigned int,
unsigned int, unsigned int,
unsigned int, unsigned int,
cmPolicies::PolicyStatus status) cmPolicies::PolicyStatus)
{ {
this->Policies[iD] = new cmPolicy(iD, this->Policies[iD] = new cmPolicy(iD);
status);
} }
//---------------------------------------------------------------------------- //----------------------------------------------------------------------------
@ -664,20 +660,11 @@ std::string cmPolicies::GetRequiredPolicyError(cmPolicies::PolicyID id)
///! Get the default status for a policy ///! Get the default status for a policy
cmPolicies::PolicyStatus cmPolicies::PolicyStatus
cmPolicies::GetPolicyStatus(cmPolicies::PolicyID id) cmPolicies::GetPolicyStatus(cmPolicies::PolicyID)
{ {
// if the policy is not know then what?
std::map<cmPolicies::PolicyID,cmPolicy *>::iterator pos =
this->Policies.find(id);
if (pos == this->Policies.end())
{
// TODO is this right?
return cmPolicies::WARN; return cmPolicies::WARN;
} }
return pos->second->Status;
}
//---------------------------------------------------------------------------- //----------------------------------------------------------------------------
std::string std::string
cmPolicies::GetRequiredAlwaysPolicyError(cmPolicies::PolicyID id) cmPolicies::GetRequiredAlwaysPolicyError(cmPolicies::PolicyID id)