kolan/CMake
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

libuv: Simplify variable initializations to satisfy Clang scan-build

Browse Source 
The Clang scan-build tool warns about assignments whose values are never
used, so initialize local variables at declaration instead.
This commit is contained in:
Brad King 2016-09-01 11:09:25 -04:00
parent 0c46750d2c
commit 3825a56493
2 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Utilities/cmlibuv/src/unix/pipe.c
View File

@ -42,13 +42,10 @@ int uv_pipe_init(uv_loop_t* loop, uv_pipe_t* handle, int ipc) {
int uv_pipe_bind(uv_pipe_t* handle, const char* name) { int uv_pipe_bind(uv_pipe_t* handle, const char* name) {
struct sockaddr_un saddr; struct sockaddr_un saddr;
const char* pipe_fname; const char* pipe_fname = NULL;
int sockfd; int sockfd = -1;
int err; int err;
pipe_fname = NULL;
sockfd = -1;
/* Already bound? */ /* Already bound? */
if (uv__stream_fd(handle) >= 0) if (uv__stream_fd(handle) >= 0)
return -EINVAL; return -EINVAL;

7
Utilities/cmlibuv/src/unix/tty.c
View File

@ -58,8 +58,8 @@ static int uv__tty_is_slave(const int fd) {
int uv_tty_init(uv_loop_t* loop, uv_tty_t* tty, int fd, int readable) { int uv_tty_init(uv_loop_t* loop, uv_tty_t* tty, int fd, int readable) {
uv_handle_type type; uv_handle_type type;
int flags; int flags = 0;
int newfd; int newfd = -1;
int r; int r;
int saved_flags; int saved_flags;
char path[256]; char path[256];
@ -72,9 +72,6 @@ int uv_tty_init(uv_loop_t* loop, uv_tty_t* tty, int fd, int readable) {
if (type == UV_FILE || type == UV_UNKNOWN_HANDLE) if (type == UV_FILE || type == UV_UNKNOWN_HANDLE)
return -EINVAL; return -EINVAL;
flags = 0;
newfd = -1;
/* Reopen the file descriptor when it refers to a tty. This lets us put the /* Reopen the file descriptor when it refers to a tty. This lets us put the
* tty in non-blocking mode without affecting other processes that share it * tty in non-blocking mode without affecting other processes that share it
* with us. * with us.